fabtests/benchmarks: Add oob_sync between test sizes to mt_bw#12116
Merged
zachdworkin merged 1 commit intoofiwg:mainfrom Apr 14, 2026
Merged
fabtests/benchmarks: Add oob_sync between test sizes to mt_bw#12116zachdworkin merged 1 commit intoofiwg:mainfrom
zachdworkin merged 1 commit intoofiwg:mainfrom
Conversation
We need a ft_oob_sync between test sizes to guarantee that the performance results are accurate. Without the sync, the sender is permitted to blast all of their sends while the receiver is stuck processing them one by one. In this case it is possible for the sender to have sent every message size while the receiver is still processing, and posting performance results, for the first or second message size. Adding the sync here will guarantee more accurate results. Signed-off-by: Zach Dworkin <zachary.dworkin@intel.com>
aingerson
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a ft_oob_sync between test sizes to guarantee that the performance results are accurate. Without the sync, the sender is permitted to blast all of their sends while the receiver is stuck processing them one by one. In this case it is possible for the sender to have sent every message size while the receiver is still processing, and posting performance results, for the first or second message size. Adding the sync here will guarantee more accurate results.