prov/efa: fix unit test linking to not affect libfabric.so#12001
Draft
sunkuamzn wants to merge 1 commit intoofiwg:mainfrom
Draft
prov/efa: fix unit test linking to not affect libfabric.so#12001sunkuamzn wants to merge 1 commit intoofiwg:mainfrom
sunkuamzn wants to merge 1 commit intoofiwg:mainfrom
Conversation
The previous implementation added "-static" to efa_LIBS when unit tests were enabled, which caused static linking flags to propagate into the main libfabric.so build. This resulted in a shared library with embedded static dependencies, causing symbol conflicts and breaking compatibility with other tests and applications. The fix isolates static linking to only the unit test binary by: 1. Removing "-static" from efa_LIBS in configure.m4 and storing cmocka flags in a separate cmocka_LIBS_STATIC variable 2. Linking the unit test binary against libfabric.a using --whole-archive to include all internal symbols (like efa_env) needed for mocking 3. Explicitly adding transitive dependencies (-lrdmacm, -libverbs, etc.) required when statically linking libfabric 4. Adding a dependency on libfabric.la to ensure proper build ordering This change requires --enable-static when building with unit tests to generate libfabric.a. Signed-off-by: Sai Sunku <sunkusa@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation added "-static" to efa_LIBS when unit tests were enabled, which caused static linking flags to propagate into the main libfabric.so build. This resulted in a shared library with embedded static dependencies, causing symbol conflicts and breaking compatibility with other tests and applications.
The fix isolates static linking to only the unit test binary by:
Removing "-static" from efa_LIBS in configure.m4 and storing cmocka flags in a separate cmocka_LIBS_STATIC variable
Linking the unit test binary against libfabric.a using --whole-archive to include all internal symbols (like efa_env) needed for mocking
Explicitly adding transitive dependencies (-lrdmacm, -libverbs, etc.) required when statically linking libfabric
Adding a dependency on libfabric.la to ensure proper build ordering
This change requires --enable-static when building with unit tests to generate libfabric.a.