fabtests/efa/multi_ep_stress: Refactor completion handling with dedicated CQ threads#11938
Open
alekswn wants to merge 1 commit intoofiwg:mainfrom
Open
fabtests/efa/multi_ep_stress: Refactor completion handling with dedicated CQ threads#11938alekswn wants to merge 1 commit intoofiwg:mainfrom
alekswn wants to merge 1 commit intoofiwg:mainfrom
Conversation
…ated CQ threads Refactor the multi-endpoint stress test to use dedicated completion queue (CQ) polling threads instead of inline polling. This change improves scalability and reduces contention when handling completions. Key changes: - Introduce cq_context structure to encapsulate CQ state with atomic completion counters and dedicated polling thread - Replace blocking wait_for_comp() with lock-free atomic-based completion tracking that runs in separate threads - Implement ft_backoff() with progressive backoff strategy (CPU pause, yield, exponential sleep) to reduce busy-waiting overhead - Remove shared CQ mutex locking in favor of lock-free atomic operations - Move CQ thread lifecycle management into setup_endpoint() and cleanup_endpoint() - Refactor sender/receiver workers to poll atomic completion counters instead of directly calling fi_cq_read() - Fix timeout handling to distinguish between -FI_ETIMEDOUT and other errors - Move shared resource setup/cleanup to run_test() for better lifecycle management This design eliminates lock contention on shared CQs and allows worker threads to continue posting operations while a dedicated thread handles completions asynchronously. Signed-off-by: Alexey Novikov <nalexey@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the multi-endpoint stress test to use dedicated completion queue (CQ) polling threads instead of inline polling. This change improves scalability and reduces contention when handling completions.
Key changes:
This design eliminates lock contention on shared CQs and allows worker threads to continue posting operations while a dedicated thread handles completions asynchronously.