Security: DOM-based Theme Injection via Unsanitized Input in Template Literal#633
Open
barttran2k wants to merge 1 commit intooffa:masterfrom
Conversation
The `changeCSS()` function directly interpolates its `theme` parameter into a URL template literal without validation. While currently called only from a `<select>` element with fixed `<option>` values, if invoked programmatically with a crafted value (e.g., via browser console or future code changes), it could load an arbitrary external stylesheet by manipulating the URL path. Affected files: index.html Signed-off-by: Trần Bách <45133811+barttran2k@users.noreply.github.com>
Owner
|
What's different than #629? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
changeCSS()function directly interpolates itsthemeparameter into a URL template literal without validation. While currently called only from a<select>element with fixed<option>values, if invoked programmatically with a crafted value (e.g., via browser console or future code changes), it could load an arbitrary external stylesheet by manipulating the URL path.Severity:
lowFile:
index.htmlSolution
Validate the
themeparameter against an allowlist of known theme names before constructing the URL:const allowedThemes = ['darkly', 'united', 'flatly', 'quartz']; if (!allowedThemes.includes(theme)) return;.Changes
index.html(modified)Testing