Security: External scripts loaded without Subresource Integrity (SRI)#628
Open
barttran2k wants to merge 1 commit intooffa:masterfrom
Open
Conversation
The `marked.min.js` and `marked-gfm-heading-id` libraries are loaded from `cdn.jsdelivr.net` without `integrity` attributes. If the CDN is compromised or serves tampered content (supply chain attack), malicious JavaScript could be injected and executed in visitors' browsers. Affected files: index.html Signed-off-by: Trần Bách <45133811+barttran2k@users.noreply.github.com>
Owner
|
Can someone with more experience in web development have a look at this PR? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
marked.min.jsandmarked-gfm-heading-idlibraries are loaded fromcdn.jsdelivr.netwithoutintegrityattributes. If the CDN is compromised or serves tampered content (supply chain attack), malicious JavaScript could be injected and executed in visitors' browsers.Severity:
mediumFile:
index.htmlSolution
Add
integrityandcrossorigin="anonymous"attributes to both<script>tags. For example:<script src="https://cdn.jsdelivr.net/npm/marked/marked.min.js" integrity="sha384-<hash>" crossorigin="anonymous"></script>. Generate the hash usingopenssl dgst -sha384 -binary <file> | openssl base64 -A.Changes
index.html(modified)Testing