Closed
Conversation
avifenesh
reviewed
Jul 6, 2025
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: |
Collaborator
There was a problem hiding this comment.
why matrix for one runner one version? just use jobs
avifenesh
reviewed
Jul 6, 2025
Collaborator
avifenesh
left a comment
There was a problem hiding this comment.
Break to logical PRs, this is an overkill.
CI, performance, each feature, etc...
You dont do 2k lines pr unless no way to break it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the Java-based message queue implementation, focusing on performance optimization, configurability, and testing capabilities. Key changes include adding asynchronous batch persistence, configurable settings, and a comprehensive performance testing framework. Below is a summary of the most important changes grouped by theme.
Core Features and Enhancements:
API Changes:
flush()for forcing pending messages to be written to disk andshutdown()for graceful termination of the queue. [1] [2]Usage Documentation:
Performance Testing:
PerformanceTestclass andrun_performance_test.shscript to measure queue performance under various conditions, including single-threaded and multi-threaded scenarios. [1] [2]Code Quality Improvements: