Conversation
Signed-off-by: habib <habiblawal@hotmail.co.uk>
Signed-off-by: habib <habiblawal@hotmail.co.uk>
Signed-off-by: habib <habiblawal@hotmail.co.uk>
| <h1>TEx</h1> | ||
| </div> | ||
|
|
||
| <Modal |
There was a problem hiding this comment.
extract tex functionality in separate demo component so that we can differentiate and encapsulate the functionality
ideally the modal should be implemented in the egeria-ui-components where there will be a new happi-graph instance
There was a problem hiding this comment.
I've changed the frontend to have a dropdown menu to choose the graph type, the only issue I'm struggling with a bit is to have the Happi Graph update with the new Graph Type state after you change it with the dropdown. If you run the code it should make sense. For example, whatever graph type you start with is ok, but then if you change the graph via the down from Inheritance to Lineage, the graph does not refresh to show the Lineage graph.
| @@ -0,0 +1,565 @@ | |||
| import * as d3 from 'd3'; | |||
There was a problem hiding this comment.
duplicating the entire code is not ok :)
There was a problem hiding this comment.
Yes you're right, I've updated this in my recent commit
| @@ -0,0 +1,565 @@ | |||
| import * as d3 from 'd3'; | |||
There was a problem hiding this comment.
duplicating the entire code is not ok, please remove if not applicable
| const mappedNodes = mapNodes(props.rawData.nodes, props.selectedNodeId); | ||
| const mappedLinks = mapLinks(props.rawData.edges, mappedNodes); | ||
|
|
||
| let selectedGraphType; |
There was a problem hiding this comment.
extract this to separate function, make it more readable
|
|
||
| addNodes(nodes, nodesGroup, graphDirection, onNodeClick); | ||
| addLinks(links, linksGroup, graphDirection, nodes); | ||
| this.state.addNodes(nodes, nodesGroup, graphDirection, onNodeClick); |
Signed-off-by: habib <habiblawal@hotmail.co.uk>
Signed-off-by: habib <habiblawal@hotmail.co.uk>
3 participants
No description provided.