Skip to content

[ADD] estate, estate_account: modules for managing real estate businesses#1284

Open
sidum-odoo wants to merge 1 commit into
odoo:19.0from
odoo-dev:19.0-technical-onboarding-sidum
Open

[ADD] estate, estate_account: modules for managing real estate businesses#1284
sidum-odoo wants to merge 1 commit into
odoo:19.0from
odoo-dev:19.0-technical-onboarding-sidum

Conversation

@sidum-odoo
Copy link
Copy Markdown

@sidum-odoo sidum-odoo commented May 19, 2026

Problem:
No existing module for managing real estate businesses.

Solution:
2 new modules : "estate" and "estate_account".
The main module "estate" allows property management with Kanban, List and Form views. Types, tags and offers can be added/assigned to a property. The flow is managed through automatic state changes when offers are received/accepted.
Additionnaly, the module "estate_account" allows automatic invoice creation when a property is sold.

Task-6229416

@robodoo
Copy link
Copy Markdown

robodoo commented May 19, 2026

Pull request status dashboard

@Megaaaaaa Megaaaaaa self-requested a review May 20, 2026 06:54
@sidum-odoo sidum-odoo changed the title Chapter 1-6 Technical Onboarding - Server 101 May 21, 2026
@sidum-odoo sidum-odoo changed the title Technical Onboarding - Server 101 Technical Onboarding - Server Framework 101 May 21, 2026
@sidum-odoo sidum-odoo force-pushed the 19.0-technical-onboarding-sidum branch 6 times, most recently from d9590a4 to 7c8b8e2 Compare May 22, 2026 09:31
@sidum-odoo
Copy link
Copy Markdown
Author

@Megaaaaaa ready for review

@sidum-odoo sidum-odoo force-pushed the 19.0-technical-onboarding-sidum branch from 7c8b8e2 to f46f1a1 Compare May 22, 2026 11:38
Copy link
Copy Markdown

@Megaaaaaa Megaaaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋

I must say I'm impressed, this is a really really good PR 👍

There is very few things to say and very few reccurring comments. Only the trailing commas and the translations. Otherwise it's rather comment about technical stuff than about guielines. Tat's the kind of thing you want to have on your PRs later. That's nice 👍

So, please keep in mind that a review is not the utlimate solution, it's only someone seeing things he would have done differently and offering an alternative. You're always free to answer with an other alternative or even say you disagree and bring your arguments. For stuff that's not just styling or conventions, don't tak the wrong habit of just blindly applying comments, you spent time developping the thing, everything you've tried doesn't show up in the diff, only the final one. You probably have very interesting things to say to the reviewer about the decisions you made.

What I would suggest you do and continue to do while you're not the most comfortable with odoo's structure is to not apply all the changes at once. For example, changing multiple compute methods at once might lead you to a lot of errors if you don't check that the new implementation doesn't break anything before working on another one. Splitting the review in multiple steps and trying to run your db in between those can save you a lot of time in the long run.

Also a quick tip for the methodology when applying reviews changes: What I like to do it put a reaction like a thumbsup on a message once I have made the change locally. Then when everything is marked with something, I push, go through my diff and mark as resolved the things that are now outdated so nothing is left forgotten.

If you have any question, don't hesitate to ask!

Comment thread estate/models/__init__.py Outdated
Comment thread estate/models/estate_property.py
Comment thread estate/models/estate_property.py
Comment thread estate/models/estate_property.py
Comment thread estate/models/estate_property.py Outdated
Comment thread estate/models/res_users.py Outdated
Comment thread estate/views/estate_property_type_views.xml Outdated
Comment thread estate/__manifest__.py Outdated
Comment thread .gitignore Outdated
Comment thread estate_account/__manifest__.py Outdated
@sidum-odoo sidum-odoo force-pushed the 19.0-technical-onboarding-sidum branch from 0cc9cca to 6b36588 Compare May 26, 2026 15:10
@sidum-odoo sidum-odoo changed the title Technical Onboarding - Server Framework 101 [ADD] estate, estate_account: modules for managing real estate businesses May 26, 2026
…sses

Problem:
No existing module for managing real estate businesses.

Solution:
2 new modules : "estate" and "estate_account".
The main module "estate" allows property management with Kanban, List and Form views. Types, tags and offers can be added/assigned to a property. The flow is managed through automatic state changes when offers are received/accepted.
Additionnaly, the module "estate_account" allows automatic invoice creation when a property is sold.

Task-6229416
@sidum-odoo sidum-odoo force-pushed the 19.0-technical-onboarding-sidum branch from 6b36588 to 5714b13 Compare May 26, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants