[ADD] estate: estate module added for real estate businesses

[sreedevk]

No description provided.

[robodoo]

[Megaaaaaa]

Hello 👋

Here's a first (official) review for you, really nice PR for a first, gj 👍

There's not much and even amongst those there quite a lot of things that repeat themselves so not a whole lot to say 😄

Keep in mind that a review is not the utlimate solution, it's only someone seeing things he would have done differently and offering an alternative. You're always free to answer with an other alternative or even say you disagree and bring your arguments. For stuff that's not just styling or conventions, don't tak the wrong habit of just blindly applying comments, you spent the time developping the thing, everything you've tried doesn't show up in the diff, only the last one. You probably have very interesting things to say to the reviewer about the decisions you made.

What I would suggest you do and continue to do while you're not the most comfortable with odoo's structure is to not apply all the changes at once. For example, changing a technical value inside a Selection field has a lot of impact and if you change everything at once, you might end up with a lot of errors when running the database. Splitting the review in multiple steps and trying to run your db in between those can save you a lot of time in the long run.

Also a quick tip for the methodology when applying reviews changes: What I like to do it put a reaction like a thumbsup on a message once I have made the change locally. Then when everything is marked with something or answered, I push, go through my diff and mark as resolved the things that are now outdated so nothing is left forgotten.

If you have any question, don't hesitate to ask!

[Megaaaaaa]

Also since you've already squashed your work into a single commit, you can spend the extra time to make it compliant to the git guidelines. We'll explain it next week anyway but you've done the hardest part, having a single commit 😄
If you do so, don't forget to update the PR title and message to remain the same as your commit's because those won't update automatically.
(and if you're not sure about the task-123, here it would be task-6229508, 6229508 being the id of your Server 101 task you can find in its url: https://www.odoo.com/odoo/project/26755/tasks/6229508)

[sreedevk]

@Megaaaaaa Thank you for the detailed review! 😄

I finished the backend framework 101 chapter entirely, addressed all your comments and the CI has passed as well.