[FIX] estate: resolving PR suggestions

Author: hazemayman1

estate/__manifest__.py

@@ -1,10 +1,7 @@
 {
     'name': "Real Estate",
     'summary': "Testing the real estate module",
-
-    'description': """
-        Testing the description real estate module
-    """,
+    'description': "Testing the description real estate module",
     'depends': ['base'],
     'data': [
         'security/ir.model.access.csv',

estate/models/estate_property.py

@@ -64,7 +64,7 @@ class EstateProperty(models.Model):
     )
 
     buyer_id = fields.Many2one(
-        'res.partner', string='Buyer', ondelete='restrict', copy=False, readonly=True
+        'res.partner', string='Buyer', ondelete='restrict', copy=False, readonly=True,
     )
 
     property_tags_ids = fields.Many2many("estate.property.tag", string="Tags")
@@ -81,9 +81,7 @@ def _compute_total_area(self):
     @api.depends("offer_ids")
     def _compute_best_offer(self):
         for record in self:
-            record.best_offer = 0
-            for offer in record.offer_ids:
-                record.best_offer = max(record.best_offer, offer.price)
+            record.best_offer = max(record.offer_ids.mapped('price'), default=0.0)
 
     @api.onchange("garden")
     def _onchange_garden(self):
@@ -104,7 +102,6 @@ def action_mark_as_cancelled(self):
             if record.state == "sold":
                 raise UserError(_("Sold properties cannot be cancelled."))
             record.state = "cancelled"
-            #TODO: Reject all offers
         return True
 
     @api.constrains('expected_price')
@@ -113,4 +110,3 @@ def _check_expected_price(self):
             for offer in record.offer_ids:
                 if offer.status == "yes" and float_compare(offer.price, 0.9 * record.expected_price, 2) < 0:
                     raise ValidationError("There is an accepted offer for an amount less than 90 percent of the new selling price, action required!")
-

estate/models/estate_property_offer.py

@@ -26,7 +26,7 @@ def create(self, vals_list):
     validity = fields.Integer(default=7)
     offer_creation_date = fields.Date(default=fields.Date.today())
     deadline = fields.Date(
-        "Offer Deadline", compute="_compute_deadline", inverse="_inverse_deadline"
+        "Offer Deadline", compute="_compute_deadline", inverse="_inverse_deadline",
     )
 
     partner_id = fields.Many2one(
@@ -65,10 +65,8 @@ def action_accept_offer(self):
         return True
 
     def action_reject_offer(self):
-        for record in self:
-            record.status = "no"
-            record.property_id.buyer_id = None
-            record.property_id.selling_price = 0
+        self.status = 'no'
+        self.property_id.write({'buyer_id': None, 'selling_price': 0})
         return True
 
     @api.constrains('price')