[IMP] estate: ch10 Validations for property prices added

Author: hazemayman1

estate/models/estate_property.py

@@ -1,11 +1,22 @@
 from odoo import api, fields, models, _
-from odoo.exceptions import UserError
+from odoo.tools import float_compare
+from odoo.exceptions import UserError, ValidationError
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Estate property model"
 
+    _check_expected_price = models.Constraint(
+        'CHECK(expected_price > 0)',
+        'Expected price of the property must be strictly positive.',
+    )
+
+    _check_selling_price = models.Constraint(
+        'CHECK(selling_price >= 0)',
+        'Selling price of the property must be strictly positive.',
+    )
+
     name = fields.Char("Title", required=True, default="Unknown")
     description = fields.Text("Description")
     postcode = fields.Char("Postcode")
@@ -93,4 +104,13 @@ def action_mark_as_cancelled(self):
             if record.state == "sold":
                 raise UserError(_("Sold properties cannot be cancelled."))
             record.state = "cancelled"
+            #TODO: Reject all offers
         return True
+
+    @api.constrains('expected_price')
+    def _check_expected_price(self):
+        for record in self:
+            for offer in record.offer_ids:
+                if offer.status == "yes" and float_compare(offer.price, 0.9 * record.expected_price, 2) < 0:
+                    raise ValidationError("There is an accepted offer for an amount less than 90 percent of the new selling price, action required!")
+

estate/models/estate_property_offer.py

@@ -1,11 +1,16 @@
 from odoo import api, fields, models, _
-from odoo.exceptions import UserError
+from odoo.tools import float_compare
+from odoo.exceptions import UserError, ValidationError
 
 
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Estate property offer"
 
+    _check_offer_price = models.Constraint(
+        'CHECK(price > 0)', 'Offer price must be strictly positive.'
+    )
+
     @api.model_create_multi
     def create(self, vals_list):
         records = super().create(vals_list)
@@ -51,6 +56,8 @@ def action_accept_offer(self):
             for offer in record.property_id.offer_ids:
                 if offer.status == "yes":
                     raise UserError(_("Already accepted an offer for this property."))
+            if float_compare(record.price, 0.9 * record.property_id.expected_price, 2) < 0:
+                raise ValidationError("Accepted offer price cannot be less than 90 percent of property price")
             record.status = "yes"
             record.property_id.buyer_id = record.partner_id
             record.property_id.selling_price = record.price
@@ -59,7 +66,13 @@ def action_accept_offer(self):
 
     def action_reject_offer(self):
         for record in self:
+            record.status = "no"
             record.property_id.buyer_id = None
             record.property_id.selling_price = 0
-            record.status = "no"
         return True
+
+    @api.constrains('price')
+    def _check_offered_price(self):
+        for record in self:
+            if float_compare(record.price, 0.9 * record.property_id.expected_price, 2) < 0:
+                raise ValidationError("Offer price cannot be less than 90 percent of property price")

estate/models/estate_property_tag.py

@@ -4,5 +4,9 @@
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Estate property tag"
+    _name_unique = models.Constraint(
+        'unique (name)',
+        'A property tag of that name already exists',
+    )
 
     name = fields.Char('Property Tag', required=True)

estate/models/estate_property_type.py

@@ -4,5 +4,9 @@
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
     _description = "Estate property type"
+    _name_unique = models.Constraint(
+        'unique (name)',
+        'A property type of that name already exists',
+    )
 
     name = fields.Char('Property Type', required=True)