[FIX] runbot: properly sort version on build error#1315
Merged
Conversation
Obvisoulsy #1312 was not enough, it was only applied on BuildErrorContent. So it was working when all build error contents had the same version ids or if they appeared in the right order. With this commit, the sorting is applied on the build error computed versions.
d-fence
force-pushed
the
19.0-builderror-version-order-subfix-moc
branch
from
1aef25a to
aecc00f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obviously #1312 was not enough, it was only applied on BuildErrorContent. So it was working when all build error contents had the same version ids or if they appeared in the right order.
With this commit, the sorting is applied on the build error computed versions.