Add JaCoCo information to ReadMe and update data test#311
Open
BukunmiOla wants to merge 2 commits intoodk-x:upgrade-jdk11from
Open
Add JaCoCo information to ReadMe and update data test#311BukunmiOla wants to merge 2 commits intoodk-x:upgrade-jdk11from
BukunmiOla wants to merge 2 commits intoodk-x:upgrade-jdk11from
Conversation
wbrunette
requested changes
Feb 20, 2025
Member
wbrunette
left a comment
There was a problem hiding this comment.
Since running tests WITHOUT jacocco is more important than with the documentation does not have it and might lead to more confusion without listing how to do both.
As you found there are issues with jacoco in some cases ... running tests normally without coverage do not have the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR picked the necessary part of PR #296 and corrects PR #301
This overall improves the ColorRuleTest of the data class
This also allows contributors to have an express information on:
How to get JaCoCo running with the project.
How to generate test coverage reports with JaCoCo.
And where to view the test coverage report.