Sets the color of the app status bar to match the app background #235
Open
wadva474 wants to merge 3 commits intoodk-x:developmentfrom
Open
Sets the color of the app status bar to match the app background #235wadva474 wants to merge 3 commits intoodk-x:developmentfrom
wadva474 wants to merge 3 commits intoodk-x:developmentfrom
Conversation
…und color in ODK-X Tables
Member
|
@wadva474 looking at your screenshots the buttons ODK-X Tables are not turning white so I cannot see the button icons. |
Author
|
The Pull Request has been updated to change PNG images used as Menus to SVG so that the menus changes color as the theme changes. Complementary PR'S
Attached is a video recording and also screenshots to effect the change. This also addresses : Video : |
This was referenced Oct 20, 2022
Member
|
@wadva474 I did a quick look and I did not notice anything wrong. Of course, testing is the only way to make sure by going through all the screens which you might want to do before the final application. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






This PR sets the app status bar to match the app background and also adds the dark theme for the app bar
screenshots :