Skip to content

Conversation

@wolfy1339
Copy link
Member

Fixes octokit/octokit.js#2904


Before the change?

After the change?

  • Endpoints that allow uploading binary data have their request body type to different types used to represent files, and are accpeted in fech

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Nov 1, 2025
@octokit
Copy link
Contributor

octokit bot commented Nov 1, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🔖 Ready in 🧰 Octokit Active Nov 2, 2025
@wolfy1339 wolfy1339 moved this from 🔖 Ready to 🆕 Triage in 🧰 Octokit Active Nov 2, 2025
wolfy1339 added a commit that referenced this pull request Dec 9, 2025
Fixes octokit/octokit.js#2904

* remove GHES 3.19 for now

It needs to be manually published, since OIDC is still in it's infancy and needs to be declared per package. Which means that new packages cannot be published from CI

---------

Co-authored-by: wolfy1339 <webmaster@wolfy1339.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@wolfy1339
Copy link
Member Author

Merged with #485

@wolfy1339 wolfy1339 closed this Dec 9, 2025
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Dec 9, 2025
@wolfy1339 wolfy1339 deleted the binary-types branch December 9, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[BUG]: uploadReleaseAsset does not accept data as buffer

4 participants