-
Notifications
You must be signed in to change notification settings - Fork 0
feat: job offers feature #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wab
wants to merge
10
commits into
main
Choose a base branch
from
claude/plan-offers-pages-011CUr7mcLL5kUPP8WW24zHp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Add comprehensive technical plan documenting the implementation of job offers list and detail pages. The plan follows existing blog/stories patterns with: - Schema definitions for offer frontmatter - Content fetching from GitHub or local filesystem - Routes for list and detail pages - Component structure with sidebar layout - i18n support for French/English
- Add OfferFrontmatterSchema with job offer fields - Add OfferFrontmatter type inference - Add offer validator and type guard functions - Update SchemaRegistry and AnyFrontmatter union type - Include fields: title, description, contractType, location, experience, education, department, salary, tags, date
- Add OfferFetcher class extending GenericContentFetcher
- Add offer validator to ContentValidators
- Create offerFetcher instance for immediate use
- Add fetchOffer and fetchOffers convenience functions
- Export all offer-related functions in content module index
- Content fetched from offers/{language} path
- Add 'offer' to CacheStrategy type - Configure offer caching: 1h max-age + 24h stale-while-revalidate - Update getCacheStrategyForPath to handle /offers routes - Matches caching strategy used for blog posts and stories
- Add '/offers' to url helper constants - Enables consistent URL referencing throughout the app
- Create _main.offers._index.tsx for offers list page - Create _main.offers.$slug.tsx for offer detail page - Implement loaders with error handling and date sorting - Add meta tags for SEO - Use offer cache strategy - Support i18n with language parameter
- Create OfferList component with grid layout - Create OfferItem component showing job cards - Create OfferArticle component using LayoutPost - Create OfferHeader for title and description - Create OfferSidebar displaying job details - Create OfferContent using PageMarkdownContainer - All components properly typed with TypeScript - Follows existing blog/stories component patterns
- Update lockfile after installing dependencies - Required for typecheck to run successfully
- Handle case when offers directory doesn't exist (404/not_found) - Return empty array without error when no offers are available - Distinguish between no content (valid) vs actual errors - Fix Biome formatting issues in all offer components - Fix import organization to match project standards - All CI checks now pass (typecheck + biome check)
- Complete feature overview - Detailed breakdown of all changes - Sample content structure - Testing checklist - Ready for PR update
5ae4d67 to
6325c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comprehensive technical plan documenting the implementation of job offers list and detail pages. The plan follows existing blog/stories patterns with: