Skip to content

Do not abort on ping failure#1238

Merged
giurgiur99 merged 2 commits intomainfrom
large-files-ping-error
Mar 1, 2026
Merged

Do not abort on ping failure#1238
giurgiur99 merged 2 commits intomainfrom
large-files-ping-error

Conversation

@giurgiur99
Copy link
Contributor

Fixes # .

Changes proposed in this PR:

  • The connection monitor runs a heartbeat (ping) on every connection every 10s. If that ping fails (e.g. timeout while the connection is busy with a large download), it was calling conn.abort(err) because abortConnectionOnPingFailure is true by default. That aborts the whole connection and all its streams, including result stream.

Copy link
Member

@bogdanfazakas bogdanfazakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giurgiur99 giurgiur99 merged commit 2920c8d into main Mar 1, 2026
39 of 43 checks passed
@giurgiur99 giurgiur99 deleted the large-files-ping-error branch March 1, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants