Feature/subhourlytimesteps#122
Open
WPringle wants to merge 2 commits into
Open
Conversation
…mal case when reading track it would just be handled in same way as before. if reading from a file which has subhourly timesteps it will now also work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a provided file in case of subhourly (e.g. 15 minute) time steps used and input in the
forecast_hourscolumn, this fix will handle without any error.As the
forecast_hoursare kept as string objects in any case it doesn't have any other downstream impacts.Note though that any track written this way could have a width of the TAU (
forecast_hours) column for an ATCF file that violates the standard, but this would be desired behavior of the user in any case.