cleanup of the OCFL filling in function, adding Chavas method for filling in pressure#109
Closed
WPringle wants to merge 3 commits into
Closed
cleanup of the OCFL filling in function, adding Chavas method for filling in pressure#109WPringle wants to merge 3 commits into
WPringle wants to merge 3 commits into
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 91.74% 91.74% -0.01%
==========================================
Files 19 19
Lines 2012 2010 -2
==========================================
- Hits 1846 1844 -2
Misses 166 166 ☔ View full report in Codecov by Sentry. |
… compute it instead of needing to take the nanmean
WPringle
force-pushed
the
cleanup/carq_hollandb
branch
from
d5c53bf to
9769866
Compare
Contributor
Author
|
@SorooshMani-NOAA @pvelissariou1 I can add in the new option for pressure filling to this branch using the Chavas et al. (2025) method found to be more accurate by Takis. |
WPringle
changed the title
Collaborator
|
@WPringle can you use a new branch? Since this is an old one it seems to be messing up with the diff and PR views |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moving carq_ref to above holland B calculation and just using that to compute it instead of needing to take the nanmean