Move legacy code to oceanarray.legacy module #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Move legacy RODB/RAPID format processing code from the main package to a dedicated oceanarray.legacy module to improve code organization and clearly separate deprecated functionality from the modern CF-compliant workflow.
- Moved legacy RODB processing modules to
oceanarray.legacysubdirectory - Updated import statements throughout the codebase to reference the new legacy module locations
- Created comprehensive documentation for the legacy modules with migration guidance
Reviewed Changes
Copilot reviewed 19 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_tools.py | Updated imports to use legacy module paths for RODB processing functions |
| tests/test_stage2.py | Minor spelling correction in skip message for better clarity |
| tests/legacy/ | Created new test directory for legacy RODB processing tests with reorganized imports |
| oceanarray/legacy/ | New legacy module with reorganized RODB processing code and updated internal imports |
| notebooks/legacy/ | Added documentation explaining deprecation of legacy notebooks |
| docs/source/ | Updated documentation to reflect legacy module reorganization and deprecation |
| README.md | Completely restructured to focus on modern processing pipeline with legacy modules noted as deprecated |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ceanarray into eleanor-patch-21
- Fix missing python-version parameter in setup-python action - Change Python version from 3.12 to 3.11 to match local environment - Make logging test more robust to handle CI environment differences - Specify oceanarray logger explicitly in caplog.at_level() - Make log message assertion conditional on caplog.text content 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CLEANUP] Move legacy code
Description:
Move legacy code for RODB format out of the main repository (into
legacy/subfolders).Update documentation.
Checklist:
pytestto check that all tests pass.pre-commit run --all-filesto lint and format the code.