Drop the .llvm_addrsig section from rewritten objects#169
Open
MisterDA wants to merge 1 commit into
Open
Conversation
MisterDA
commented
Jun 16, 2026
dra27
reviewed
Jun 16, 2026
The address-significance table emitted by clang holds symbol table indices, which become stale when flexlink rewrites an object's symbol table to add the relocation table. lld-link rejects objects with an invalid `.llvm_addrsig` section. The section is an optional hint for the linker's identical-code-folding pass and can safely be dropped.
7c9c521 to
0ce9af9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The address-significance table emitted by Clang holds symbol table indices, which become stale when flexlink rewrites an object's symbol table to add the relocation table. lld-link rejects objects with an invalid
.llvm_addrsigsection. The section is an optional hint for the linker's identical-code-folding pass and can safely be dropped.It is also possible to tell Clang not to emit this section with
-fno-addrsig.Proper handling of this section could come later, for now it's easy to silently ignore it.
See also: