Skip to content

Fix dependency bounds for dune-action-trace#13730

Open
shonfeder wants to merge 2 commits intomainfrom
shonfeder/fix-dune-action-trace-package
Open

Fix dependency bounds for dune-action-trace#13730
shonfeder wants to merge 2 commits intomainfrom
shonfeder/fix-dune-action-trace-package

Conversation

@shonfeder
Copy link
Member

@shonfeder shonfeder commented Mar 4, 2026

Necessary for #13674 (as per #13674 (comment))

Followup to #13267

@shonfeder shonfeder requested review from Alizter and rgrinberg March 4, 2026 19:14
@shonfeder shonfeder mentioned this pull request Mar 4, 2026
14 tasks
@Alizter
Copy link
Collaborator

Alizter commented Mar 4, 2026

This library is intended to be public. I'm not following your explanation of with-test however. If you look in otherlibs/dune-action-trace you will see there are tests which ideally should be run wtih with-test. Could you elaborate on what you were observing?

@Alizter
Copy link
Collaborator

Alizter commented Mar 4, 2026

Specifically the -p dune-action-trace arg to dune will actually remove all the stanzas unrealted to the package from being considered, so only the tests related to dune-action-trace should be run. Even more since the package stanza has a dir field which tells dune only this directory should be considered when filtering for that package.

@shonfeder
Copy link
Member Author

shonfeder commented Mar 4, 2026

This library is intended to be public. I'm not following your explanation of with-test however. If you look in otherlibs/dune-action-trace you will see there are tests which ideally should be run with with-test.

I'm following the pattern of #12954 -- if the tests are meant to be run during opam installation --with-test, then please fix the tests so that they pull in the required dependencies and/or don't run unrelated code.

Could you elaborate on what you were observing?

https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/118a690db616b1df5c53d5fa00eb70791a80ae2c/variant/compilers,4.12,dune-action-trace.3.22.0~alpha0,tests

Signed-off-by: Shon Feder <shon.feder@gmail.com>
Addresses the lower-bounds packaging error detected in the opam-repo-ci

Signed-off-by: Shon Feder <shon.feder@gmail.com>
@shonfeder shonfeder force-pushed the shonfeder/fix-dune-action-trace-package branch from 70f1974 to b1d0c09 Compare March 5, 2026 02:41
@shonfeder
Copy link
Member Author

I've removed the part of this addressing the test dependencies, and instead filed an issue for that #13732

This way we can get the simplest part here merged, and those with context on the dune-action-trace package can decide how that should be fixed.

@shonfeder shonfeder changed the title Fix packaging for dune-action-trace Fix dependency bounds for dune-action-trace Mar 5, 2026
@shonfeder shonfeder requested a review from Alizter March 5, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants