Skip to content

fix(pkg): dune show depexts prints on stdout#13717

Merged
Alizter merged 1 commit intoocaml:mainfrom
Alizter:push-svpwyrvlluuz
Mar 6, 2026
Merged

fix(pkg): dune show depexts prints on stdout#13717
Alizter merged 1 commit intoocaml:mainfrom
Alizter:push-svpwyrvlluuz

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Mar 2, 2026

Signed-off-by: Ali Caglayan <alizter@gmail.com>
@punchagan
Copy link
Copy Markdown
Collaborator

On a side note, should pkg search be doing something similar?

@Alizter
Copy link
Copy Markdown
Collaborator Author

Alizter commented Mar 3, 2026

@punchagan That may make sense. I think the main benefit of doing it for dune show depexts is that it will be composed with other commands, for which stdout is more convenient. Do you think that will be the case with dune pkg search?

@Leonidas-from-XIV
Copy link
Copy Markdown
Collaborator

I definitely see this less with dune pkg search (however dune pkg search | grep REGEXP is something I could definitely see happening) but in general I think we should have a way to output to stdout.

Stdout is meant for user-requested output (like dune show) and stderr is for other information (e.g. warnings and I guess progress information), so I think going through the commands and changing where they are written to is probably a decent UX improvement.

@Alizter Alizter merged commit 5a6557d into ocaml:main Mar 6, 2026
29 checks passed
@Alizter Alizter deleted the push-svpwyrvlluuz branch March 6, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants