Use Bin.add_exe instead of concat-ing Bin.exe always#13620
Merged
Alizter merged 1 commit intoocaml:mainfrom Mar 24, 2026
Merged
Use Bin.add_exe instead of concat-ing Bin.exe always#13620Alizter merged 1 commit intoocaml:mainfrom
Alizter merged 1 commit intoocaml:mainfrom
Conversation
punchagan
force-pushed
the
fix-which-candidates
branch
from
47d13e4 to
d25aecf
Compare
punchagan
changed the title
punchagan
force-pushed
the
fix-which-candidates
branch
from
d25aecf to
c838c92
Compare
punchagan
force-pushed
the
fix-which-candidates
branch
from
c838c92 to
a83cab8
Compare
Alizter
added a commit
that referenced
this pull request
Mar 20, 2026
This PR demonstrates a bug with `which` on Windows where `.exe.exe` candidates are generated and searched for. Will be fixed by: - #13620 Has been checked to run on Windows. ppx_expect doesn't work on windows so we opt to use the `.expected` functionality of `(test)`.
Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
punchagan
force-pushed
the
fix-which-candidates
branch
from
a83cab8 to
222e065
Compare
Alizter
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with
whichon Windows where.exe.execandidates are generated and searched for.