fix(pkg): fix extra files with autolocking #13595
fix(pkg): fix extra files with autolocking #13595Alizter wants to merge 2 commits intoocaml:mainfrom
Conversation
073a829 to
d8db822
Compare
d8db822 to
999a575
Compare
punchagan
left a comment
There was a problem hiding this comment.
Thanks for the clean up, alongside the bug fix!
|
This change fixes a race condition with dev tools that triggers some other hidden bugs. I will factor those fixes out first and fix those issues, so marking this as draft in the meantime. |
999a575 to
fb07ba2
Compare
|
Important technical notes about this patch: When we copy a source lock directory to an internal one we are at the mercy of the interpreter of the pkg rules to read this lock directory correctly. At no point do we record the fact that there are extra files, we instead leave this to be inferred by the directory structure. The previous implementation was inferring it directly from the source location which didn't work in every case, and left out autolocking. |
fb07ba2 to
171aeed
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Signed-off-by: Ali Caglayan <alizter@gmail.com>
171aeed to
1c3b41d
Compare
Reviewed an earlier iteration of the code and is busy at the moment.
shonfeder
left a comment
There was a problem hiding this comment.
This looks great to me. Super clear. Thanks!
This patch makes sure we are using the internal lock directory rather than the source one. The previous code was traversing the lock directory source for the extra files and therefore autolocking, which directly produces the internal lock, would fail.
pkg enabledfails to build an oxcaml project without a lock #12851