win-dshow: use the obs samplingRate #5033
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WizardCM
changed the title
WizardCM
added
the
Feedback required
PatTheMav
reviewed
Jan 10, 2024
| // get the obs sample_rate | ||
| uint32_t sampleRate = audio_output_get_sample_rate(obs_get_audio()); | ||
|
|
||
| audioConfig.sampleRate = |
Member
There was a problem hiding this comment.
Move the comment above the line to avoid clang-format having to break it up
PatTheMav
reviewed
Jan 10, 2024
|
|
||
| audioConfig.sampleRate = | ||
| sampleRate; // try to set the desired samplerate | ||
| blog(LOG_INFO, "\tobs samplerate: %d", audioConfig.sampleRate); |
Member
There was a problem hiding this comment.
Avoid using tabstops for log output.
Member
|
Please address the review comments and rebase to current master branch. If no action is taken until next week I'll consider this PR stale and close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dependency: obsproject/libdshowcapture#33
Description
set the desired sampling rate for the audio capture device using
audio_output_get_sample_rate()Motivation and Context
Please see obsproject/libdshowcapture#33
How Has This Been Tested?
obsproject/libdshowcapture#33
Types of changes
get the desired sampling rate using
audio_output_get_sample_rate()Checklist: