-
Notifications
You must be signed in to change notification settings - Fork 90
deps.ffmpeg: Update SVT-AV1 to 3.0.0 #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
deps.ffmpeg: Update SVT-AV1 to 3.0.0 #278
Conversation
SVT-AV1 3.0.0 no longer vendors cpuinfo. They now use CMake's
FetchContent by default, unless we specify at configure time to use an
external copy. This means that we cannot Patch cpuinfo before Configure.
If we determine that the patch is no longer required, then we can simply
remove it.
If we determine that the patch is still required, then we have to
either:
A. upstream our patch, then get SVT-AV1 to update the commit they use
for FetchContent
B. figure out if we can use a SYSTEM/EXTERNAL cpuinfo
C. disable cpuinfo (USE_CPUINFO=OFF)
|
It looks like FFmpeg 7.1 doesn't support SVT-AV1 3.0.0, so this will have to wait for a future update. However, my questions about our cpuinfo patch remain, and we should probably think about those in advance. |
|
Apparently SVT-AV1 have no "deprecation then replace" process to prepare for some kind of API/ABI breakage. Edit: Got cherry-picked to 7.1 branch (FFmpeg/FFmpeg@68b5db2). |
I just checked their |
PatTheMav
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes themselves look good, the FFmpeg incompatibility has been mentioned by Tytan already.
|
Will probably have to wait for a new stable tag of FFmpeg before we can merge this, but glad to have the review. |
|
Now that FFmpeg 7.1.1 has been merged, will this PR be reviewed? |
No, because 7.1.1 does not contain the fix commit. We will re-review this when there is a stable tag that does. |
|
FFmpeg 8 and SVT 3.1 have been released, will this be reviewed? |
We're aware that FFmpeg 8 and SVT-AV1 3.1 have been released. However, we're in the middle of the OBS Studio 32.0 beta. Updates to obs-deps will be reviewed when that release cycle is complete and as time allows. |
Description
Update SVT-AV1 to 3.0.0.
SVT-AV1 3.0.0 no longer vendors cpuinfo (see SVT-AV1 release notes and the commit in question). They now use CMake's FetchContent by default, unless we specify at configure time to use an external copy. This means that we cannot Patch cpuinfo before Configure.
If we determine that the patch is no longer required, then we can simply remove it.
If we determine that the patch is still required, then we have to either:
A. upstream our patch, then get SVT-AV1 to update the commit they use
for FetchContent
B. figure out if we can use a SYSTEM/EXTERNAL cpuinfo
C. disable cpuinfo (USE_CPUINFO=OFF)
Motivation and Context
Want to explore keeping dependencies up to date while managing our patches.
How Has This Been Tested?
Built locally on Windows 11, and I think I built OBS Studio against that though I do not have clear notes on it. I'd like further review to try to understand what choices we have for dealing with the new cpuinfo changes.
Types of changes
Checklist: