Add HRA spleen NTR batch outputs and review reports#3722
Conversation
Generated via bulk_ntr_workflow from source_data/spleen.csv. Pipeline completed through Stage 4: - 9 new UBERON leaf terms in final template - 0 group terms - 1 confirmed existing match excluded - 0 possible matches identified - 0 out-of-scope terms - 0 manual-curation items QC status: - 0 [PENDING] definitions - 0 INFER/UNRESOLVABLE/NEEDS_MAPPING markers Includes: - Template and groups TSVs in src/templates/ - Detailed review reports: candidates, errors, input, name_corrections - Source data snapshot in bulk_ntr_workflow/source_data/ Signed-off-by: @dragon-ai-agent
|
Claude finished @zhengj2007's task in 5m 5s —— View job PR Review: Add HRA spleen NTR batch outputs and review reportsChecklist:
SummaryThis PR adds ROBOT template outputs for 9 new spleen anatomy terms (IDs Several issues need attention before merge or before the template is applied via ROBOT: 🟡 IMPORTANT Issues1. Malformed DOI URL in
This URL is invalid and will produce a malformed xref in the ontology. Correct form: 2. Space in PMID reference for
3. Non-standard capitalisation in LABEL values UBERON convention uses lowercase for anatomical term names (compare
The pipeline's 4. "Inner PALS" / "Outer PALS" — abbreviation should be expanded "PALS" stands for periarterial lymphatic sheath (= UBERON:0001960). Using an abbreviation as the primary label is not UBERON convention. The labels should be 5. UBERON:0006804 is defined as a type of tissue (reticular connective tissue). A ring fiber is an individual structural fiber, not a tissue type. Classifying
🔵 Suggestions6. The term is defined in general terms (not spleen-specific), with only 7. Stage 5 (ODK registration) is pending The templates are staged in 8. ASCTB-TEMP IRIs in All terms include Parent term verificationAll UBERON parent IDs resolve correctly:
Recommendation: REQUEST CHANGES — The malformed DOI URL (issue 1), capitalization issues (issues 3–4), and the potential is_a misclassification for Ring Fiber (issue 5) should be resolved before this template is used to generate ontology terms. |
There was a problem hiding this comment.
Several issues need attention before this template is applied:
🟡 IMPORTANT:
- Malformed DOI URL in 'arterial capillary' def_xref: 'https://doi.org/ 10.1182/ bloodadvances.2017015073' has spaces and is invalid.
- 'PMID: 20126587' has a space after the colon in Superficial Mantle Zone def_xref.
- Multiple LABEL values use non-UBERON capitalization: 'Inner Mantle Zone', 'Superficial Mantle Zone', 'Ring Fiber', 'Splenic Red Pulp Stroma', 'Inner PALS', 'Outer PALS' — all should be lowercase.
- 'Inner PALS'/'Outer PALS' use an abbreviation; labels should be expanded to 'inner periarterial lymphatic sheath' / 'outer periarterial lymphatic sheath'.
- Ring Fiber is_a UBERON:0006804 (reticular tissue): a ring fiber is an individual fiber, not a tissue type — this is_a parent may be a logical misclassification.
See the full review in the PR comment for details and suggestions.
Generated via bulk_ntr_workflow from source_data/spleen.csv.
Pipeline completed through Stage 4:
QC status:
Includes:
Signed-off-by: @dragon-ai-agent