Skip to content

Add HRA placenta NTR batch outputs and review reports#3721

Open
zhengj2007 wants to merge 1 commit into
masterfrom
add-hra-placenta-ntr
Open

Add HRA placenta NTR batch outputs and review reports#3721
zhengj2007 wants to merge 1 commit into
masterfrom
add-hra-placenta-ntr

Conversation

@zhengj2007
Copy link
Copy Markdown
Collaborator

Generated via bulk_ntr_workflow from source_data/placenta.csv.

Pipeline completed through Stage 4:

  • 2 new UBERON leaf terms in final template (endometrial lymphatic vessel, villous mesenchyme)
  • 0 group terms
  • 14 confirmed existing matches excluded
  • 2 possible matches identified (chorionic mesoderm→UBERON:0003265, others)
  • 0 out-of-scope terms
  • 0 manual-curation items

Resolved final pending row (UBERON_8930179 chorionic mesoderm) by excluding as duplicate of UBERON:0003265 (chorionic mesenchyme).

Includes:

  • Template and groups TSVs in src/templates/
  • Detailed review reports: candidates, errors, input, name_corrections
  • Source data snapshot in bulk_ntr_workflow/source_data/

Generated via bulk_ntr_workflow from source_data/placenta.csv.

Pipeline completed through Stage 4:
- 2 new UBERON leaf terms in final template (endometrial lymphatic vessel, villous mesenchyme)
- 0 group terms
- 14 confirmed existing matches excluded
- 2 possible matches identified (chorionic mesoderm→UBERON:0003265, others)
- 0 out-of-scope terms
- 0 manual-curation items

Resolved final pending row (UBERON_8930179 chorionic mesoderm) by excluding as duplicate of UBERON:0003265 (chorionic mesenchyme).

Includes:
- Template and groups TSVs in src/templates/
- Detailed review reports: candidates, errors, input, name_corrections
- Source data snapshot in bulk_ntr_workflow/source_data/
@ai4c-agent
Copy link
Copy Markdown

ai4c-agent Bot commented May 26, 2026

Claude finished @zhengj2007's task in 6m 33s —— View job


PR Review: Add HRA Placenta NTR Batch Outputs

Review checklist:

  • Hierarchy and parents are consistent
  • Definitions and supporting references look adequate (partially — see issues)
  • Obsolete or replacement handling is safe (N/A — no obsoletions)
  • OBO and ODK conventions appear preserved (partially — see issues)
  • No obvious CI, auth, or workflow regression (partially — see issues)

Summary

This PR adds two new leaf terms for the HRA placenta batch (endometrial lymphatic vessel, villous mesenchyme) and supporting workflow reports. The NTR pipeline was executed correctly and most content is well-formed. However, three issues need attention before merge.


🟡 IMPORTANT: Undeclared file changes

The PR description lists 7 files, but the actual diff includes 9 files — two unmentioned changes:

src/mappings/biomappings.sssom.tsv (557 lines changed):

  • Version downgraded from 0.5.1-dev-ec7849df0.5.0-dev-528eae3f
  • Column structure changed (the reviewer_id column appears to have been dropped from TSV rows, matching a schema change in the upstream biomappings release)

src/ontology/uberon.Makefile (15 lines changed):

  • Removes the biomappings: convenience target
  • Adds a new dependency on $(TMPDIR)/biomappings.sssom.yml and a wget rule to fetch it

These appear unrelated to the HRA placenta NTR work. The Makefile change looks like a legitimate improvement (adds yml metadata support for the biomappings mirror), but the version downgrade in the biomappings snapshot is unexpected. Please confirm these changes are intentional and describe them in the PR body.


🟡 IMPORTANT: Villous mesenchyme — possible duplicate not explicitly resolved

UBERON:8930189 villous mesenchyme is being created despite the pipeline's own candidates.tsv flagging it as a possible_match for the existing UBERON:8600023 placental villous stroma:

UBERON:8600023 is defined as: "A stroma that is part of a chorionic villus"

The new term is defined as: "A mesenchyme that is part of a chorionic villus"

From a biological standpoint, mesenchyme (embryonic/undifferentiated connective tissue) and stroma (mature supportive tissue framework) are conceptually distinct — so a new term may be warranted. However, the pipeline explicitly flagged this for curator review, and the PR creates the term without documenting the rationale. Please either:

(a) Add a comment on the new term explaining why it's distinct, e.g.:

comment: Villous mesenchyme refers to the embryonic connective tissue core of the developing chorionic villus; distinct from placental villous stroma (UBERON:8600023) which denotes the mature stromal compartment.

(b) Or, if synonymous, add villous mesenchyme as a synonym of UBERON:8600023 instead.


🟡 IMPORTANT: PMIDs for villous mesenchyme not verifiable

The two def_xref PMIDs for UBERON:8930189 could not be confirmed via web search:

  • PMID:42146334
  • PMID:42048630

These are very high-numbered PMIDs (~42 million) that would represent very recent publications. Web search returned no results for either. Please verify these are real, indexed PubMed articles. If they are preprints or not yet indexed, substitute with a confirmed DOI or PMID.

By contrast, the PMIDs for endometrial lymphatic vessel are all confirmed valid:

  • ✅ PMID:19001552 — "Endometrial angiogenesis, vascular maturation, and lymphangiogenesis"
  • ✅ PMID:17981324 — "Endometrial lymphangiogenesis"
  • ✅ PMID:17347164 — "Lymphangiogenesis of normal endometrium and endometrial adenocarcinoma"

✅ What looks good

  • ID allocation: UBERON:8930180 and UBERON:8930189 both fall within Jie Zheng's allocated range (8930000–8930999) per uberon-idranges.owl
  • Parent terms verified: UBERON:0001473 (lymphatic vessel), UBERON:0001295 (endometrium), UBERON:0003104 (mesenchyme), UBERON:0007106 (chorionic villus) ✓
  • Definitions are Aristotelian in form and anatomically accurate
  • Subset, dcterms:date, dcterms:contributor, RO:0002175 columns populated correctly
  • No new IDs conflict with existing ontology terms
  • Confirmed-match exclusions (14 terms) correctly handled in candidates.tsv
  • Groups template is present and empty (correct — no group terms in this batch)

🔵 SUGGESTION

The Wikipedia_image for endometrial lymphatic vessel is Wikipedia:Endometrium. No dedicated article exists for endometrial lymphatic vessels, so this is acceptable, but a more specific page (e.g., for uterine lymphatics) would be marginally more informative if one becomes available.

Copy link
Copy Markdown

@ai4c-agent ai4c-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on this PR. Key issues:

  1. Undeclared file changes: src/mappings/biomappings.sssom.tsv (version downgrade 0.5.1-dev→0.5.0-dev, column structure change) and src/ontology/uberon.Makefile are modified but not mentioned in the PR description. Please confirm these are intentional.

  2. Villous mesenchyme possible duplicate unresolved: The pipeline's candidates.tsv flags villous mesenchyme as a possible_match for existing UBERON:8600023 placental villous stroma ('A stroma that is part of a chorionic villus'). The PR creates UBERON:8930189 without documenting why it's distinct. Please add a comment or explanation — either justify the new term (mesenchyme vs stroma distinction) or make it a synonym of UBERON:8600023.

  3. Unverifiable PMIDs: PMID:42146334 and PMID:42048630 for villous mesenchyme could not be confirmed via web search. Please verify these are indexed in PubMed before merge.

Full review details in the Claude comment on this PR.

Copy link
Copy Markdown

@ai4c-agent ai4c-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes. Key issues:

  1. Undeclared file changes: src/mappings/biomappings.sssom.tsv (version downgrade 0.5.1-dev to 0.5.0-dev) and src/ontology/uberon.Makefile modified but not mentioned in PR description.
  2. Villous mesenchyme (UBERON:8930189) flagged as possible duplicate of UBERON:8600023 (placental villous stroma) in the pipeline's own candidates.tsv. New term created without documenting rationale.
  3. PMIDs for villous mesenchyme (42146334, 42048630) could not be verified via web search.
    See full review in the PR comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant