Add HRA placenta NTR batch outputs and review reports#3721
Conversation
Generated via bulk_ntr_workflow from source_data/placenta.csv. Pipeline completed through Stage 4: - 2 new UBERON leaf terms in final template (endometrial lymphatic vessel, villous mesenchyme) - 0 group terms - 14 confirmed existing matches excluded - 2 possible matches identified (chorionic mesoderm→UBERON:0003265, others) - 0 out-of-scope terms - 0 manual-curation items Resolved final pending row (UBERON_8930179 chorionic mesoderm) by excluding as duplicate of UBERON:0003265 (chorionic mesenchyme). Includes: - Template and groups TSVs in src/templates/ - Detailed review reports: candidates, errors, input, name_corrections - Source data snapshot in bulk_ntr_workflow/source_data/
|
Claude finished @zhengj2007's task in 6m 33s —— View job PR Review: Add HRA Placenta NTR Batch OutputsReview checklist:
SummaryThis PR adds two new leaf terms for the HRA placenta batch ( 🟡 IMPORTANT: Undeclared file changesThe PR description lists 7 files, but the actual diff includes 9 files — two unmentioned changes:
These appear unrelated to the HRA placenta NTR work. The Makefile change looks like a legitimate improvement (adds yml metadata support for the biomappings mirror), but the version downgrade in the biomappings snapshot is unexpected. Please confirm these changes are intentional and describe them in the PR body. 🟡 IMPORTANT: Villous mesenchyme — possible duplicate not explicitly resolved
The new term is defined as: "A mesenchyme that is part of a chorionic villus" From a biological standpoint, mesenchyme (embryonic/undifferentiated connective tissue) and stroma (mature supportive tissue framework) are conceptually distinct — so a new term may be warranted. However, the pipeline explicitly flagged this for curator review, and the PR creates the term without documenting the rationale. Please either: (a) Add a comment on the new term explaining why it's distinct, e.g.:
(b) Or, if synonymous, add 🟡 IMPORTANT: PMIDs for villous mesenchyme not verifiableThe two
These are very high-numbered PMIDs (~42 million) that would represent very recent publications. Web search returned no results for either. Please verify these are real, indexed PubMed articles. If they are preprints or not yet indexed, substitute with a confirmed DOI or PMID. By contrast, the PMIDs for
✅ What looks good
🔵 SUGGESTIONThe |
There was a problem hiding this comment.
Requesting changes on this PR. Key issues:
-
Undeclared file changes:
src/mappings/biomappings.sssom.tsv(version downgrade 0.5.1-dev→0.5.0-dev, column structure change) andsrc/ontology/uberon.Makefileare modified but not mentioned in the PR description. Please confirm these are intentional. -
Villous mesenchyme possible duplicate unresolved: The pipeline's
candidates.tsvflagsvillous mesenchymeas a possible_match for existingUBERON:8600023 placental villous stroma('A stroma that is part of a chorionic villus'). The PR creates UBERON:8930189 without documenting why it's distinct. Please add a comment or explanation — either justify the new term (mesenchyme vs stroma distinction) or make it a synonym of UBERON:8600023. -
Unverifiable PMIDs: PMID:42146334 and PMID:42048630 for
villous mesenchymecould not be confirmed via web search. Please verify these are indexed in PubMed before merge.
Full review details in the Claude comment on this PR.
There was a problem hiding this comment.
Requesting changes. Key issues:
- Undeclared file changes: src/mappings/biomappings.sssom.tsv (version downgrade 0.5.1-dev to 0.5.0-dev) and src/ontology/uberon.Makefile modified but not mentioned in PR description.
- Villous mesenchyme (UBERON:8930189) flagged as possible duplicate of UBERON:8600023 (placental villous stroma) in the pipeline's own candidates.tsv. New term created without documenting rationale.
- PMIDs for villous mesenchyme (42146334, 42048630) could not be verified via web search.
See full review in the PR comment.
Generated via bulk_ntr_workflow from source_data/placenta.csv.
Pipeline completed through Stage 4:
Resolved final pending row (UBERON_8930179 chorionic mesoderm) by excluding as duplicate of UBERON:0003265 (chorionic mesenchyme).
Includes: