Add HRA lymph NTR template (41 new terms)#3718
Conversation
Generated via bulk_ntr_workflow from source_data/lymph.csv (46 input rows). Pipeline completed through Stage 4: - 41 new UBERON terms in leaf template - 0 group terms - 3 confirmed existing matches excluded - 1 out-of-scope term excluded - 1 manual-curation term flagged - 7 name corrections reported Resolved final pending row by removing 'ASCTB-TEMP_medial-lymph-node-of-common-illiac-lymph-nodes' from template, as it is a confirmed existing match to UBERON:0037532 (recorded in candidates.tsv). Signed-off-by: dragon-ai-agent <dragon-ai-agent@users.noreply.github.com>
|
Claude finished @zhengj2007's task in 6m 18s —— View job PR Review: Add HRA lymph NTR template (41 new terms)
Review Checklist
🔴 CRITICAL Issues1. Six terms in
2. Semantically wrong
UBERON:0001631 = thoracic duct. The definitions correctly state these vessels drain toward the thoracic duct, but they are not part of the thoracic duct. There is no intercostal space term in UBERON, so the 3. Duplicate FMA:12775 xref will corrupt cross-reference mappings
Three UBERON terms sharing one FMA ID will produce three-way bidirectional mapping conflicts. The two new terms should either have no FMA xref, or be mapped to distinct FMA IDs (if they exist). 4. "left lateral aortic lymph node" name collides with an existing RELATED synonym in UBERON:0016386 The new term UBERON_8930123 uses exactly this string as its primary label. If a new separate concept is justified, the RELATED synonym on UBERON:0016386 must be updated or removed before merging to avoid label duplication. Similarly, the 🟡 IMPORTANT Issues5. "epitrochlear lymph node" (UBERON_8930117) may be redundant with UBERON:0038870
6.
A lymphatic vessel is typically 7.
8.
9. ~15 terms lack PMID support The following terms have only an ASCTB-TEMP URI as
UBERON guidelines prefer at least one PMID per definition. The ASCTB-TEMP IRI is a provenance link to the HRA source, not a citable publication. 🔵 Suggestions10. "circumflex lymphatic channel" (UBERON_8930109) has no 11. "right lateral aortic lymph node" (UBERON_8930141): Unlike its left counterpart, UBERON:0016386 does not carry "right lateral aortic lymph node" as a synonym, so there is no pre-existing label conflict. The is_a parent ( 12. "left anterior mediastinal lymph node" (UBERON_8930121) part_of choice: Consider SummaryThis PR introduces a well-structured NTR template from the HRA lymph source data. The pipeline-level decisions (excluded confirmed matches, flagged manual curation items, corrected naming errors) are documented and largely sound. However, four critical issues must be resolved before the template can build and produce valid OWL:
Additionally, the epitrochlear/cubital overlap (issue #5) warrants explicit curator verification before the term is committed to the ontology. |
There was a problem hiding this comment.
Four critical issues must be resolved before this template can build:
- UNRESOLVABLE: prefix in
part_offields for 6 terms — not a valid OBO/ROBOT IRI, will break the build. - Wrong
part_ofparent: UBERON_8930115 and UBERON_8930116 usepart_of UBERON:0001631(thoracic duct), but these vessels drain toward the thoracic duct — they are not part of it. - Duplicate FMA:12775 xref: UBERON_8930121 and UBERON_8930124 both carry FMA:12775, which is already mapped to UBERON:0035520. Three-way mapping conflict will corrupt cross-references.
- Label collision: "left lateral aortic lymph node" (UBERON_8930123) duplicates an existing RELATED synonym on UBERON:0016386; the synonym on the existing term must be updated or removed.
Additional important items: epitrochlear lymph node (UBERON_8930117) possible redundancy with UBERON:0038870 needs curator sign-off; ~15 terms lack PMID support; several part_of targets need review (UBERON:0007302 for UBERON_8930113; UBERON:0003728 vs :0008820 for UBERON_8930121). Full details in the inline review comment.
Generated via bulk_ntr_workflow from source_data/lymph.csv (46 input rows).
Pipeline completed through Stage 4:
Resolved final pending row by removing
'ASCTB-TEMP_medial-lymph-node-of-common-illiac-lymph-nodes' from template, as it is a confirmed existing match to UBERON:0037532 (recorded in candidates.tsv).