Add HRA eye NTR template: inner/outer cortex of lens#3713
Conversation
Generated via bulk_ntr_workflow from bulk_ntr_workflow/eye.csv (HRA ASCTB unmapped terms, eye table). New terms: - UBERON:9900001 inner cortex of lens (part_of UBERON:0000389 lens cortex) - UBERON:9900002 outer cortex of lens (part_of UBERON:0000389 lens cortex) Both classified as is_a UBERON:0034944 (zone of organ), following the pattern of lens nucleus (UBERON:0000390). Definitions reference PMID:10550792 and PMID:20171212. Source labels 'Inner cortex' / 'Outer cortex' were renamed for disambiguation (see src/templates/hra-eye-reports/name_corrections.tsv); curator may add the originals as narrow synonyms. Stage 5 registered hra_eye.owl as a template-driven component in uberon-odk.yaml and added the corresponding import to uberon-edit.obo. The empty groups template was removed (no group terms in this batch). Note: 'sh run.sh make update_repo' was not run (Docker unavailable); component OWL will be generated on next ODK build. Signed-off-by: dragon-ai-agent <dragon-ai-agent@users.noreply.github.com>
|
Claude finished @zhengj2007's task in 6m 5s —— View job PR Review: Add HRA eye NTR template: inner/outer cortex of lensReview checklist:
Tasks:
OverviewThis PR adds two new terms — 🔵 SUGGESTION — PR description states wrong IDsFile: PR description / The PR description says:
But the actual final template
The 99xxxxx IDs are placeholder NTR IDs from the initial workflow stage; the final assigned IDs are 8930000/8930001. Checking the ontology, the 893xxxx range is currently unoccupied (the adjacent block 🔵 SUGGESTION — ASCTB-TEMP IRIs appear in
|
| Claim | Check |
|---|---|
inner/outer cortex of lens is_a zone of organ (UBERON:0034944) |
✅ Consistent — lens nucleus uses the same genus |
inner/outer cortex of lens part_of lens cortex (UBERON:0000389) |
✅ Anatomically sound; no ID collision; part_of chain reaches lens correctly |
| No existing UBERON term for these structures | ✅ candidates.tsv is empty; confirmed_matches = [] in definition JSON |
ODK config
The uberon-odk.yaml addition follows the exact same pattern as hra_skeleton.owl:
- filename: hra_eye.owl
use_template: true
templates:
- hra-eye.template.tsvThe uberon-edit.obo import line is in alphabetical order among other HRA component imports. Both changes look correct.
Note on PMID verification
Could not verify PMID:10550792 and PMID:20171212 directly (EuropePMC tool requires permission grant). The curator should confirm these PMIDs describe inner/outer cortex structure of the crystalline lens. The workflow agent reports they were found and are relevant, which is consistent with the anatomically detailed definitions.
Merge recommendation
Approve with suggestions. No critical issues. The main action item is to correct the PR description (actual IDs are UBERON:8930000/8930001, not 9900001/9900002) and confirm the 8930xxx range is formally allocated. The ASCTB-TEMP-in-def_xref and synonym gaps are minor best-practice issues that can be addressed in a follow-up.
There was a problem hiding this comment.
Approve with suggestions. No critical issues found.
Hierarchy: inner/outer cortex of lens is_a zone of organ (UBERON:0034944), part_of lens cortex (UBERON:0000389) — anatomically sound and consistent with the lens nucleus design pattern.
Definitions: Aristotelian definitions with PMID references are adequate. (PMIDs could not be verified via EuropePMC in this run — curator should confirm PMID:10550792 and PMID:20171212 describe lens cortex inner/outer zones.)
ODK config: hra_eye.owl component registration in uberon-odk.yaml and the import line in uberon-edit.obo both follow established HRA precedent correctly.
Minor notes to address:
- PR description cites UBERON:9900001/9900002 (placeholder NTR IDs) rather than the actual assigned IDs UBERON:8930000/8930001. Please update the description and confirm the 8930xxx block is formally allocated.
- ASCTB-TEMP source IRIs appear in def_xref alongside PMIDs; these are better placed in the xref column.
- Narrow synonyms 'Inner cortex' / 'Outer cortex' (per name_corrections.tsv) are deferred — acknowledged in PR body.
- Inner/outer cortex definitions are circularly cross-referenced; grounding inner cortex on 'immediately surrounding the lens nucleus' would improve clarity.
cmungall
left a comment
There was a problem hiding this comment.
Can someone document the workflow that is being used to add two terms?
I am not familiar with how HRA terms were added in the past but this is way too complex for two terms that follow standard DPs
|
@dragon-ai-agent please look deeper into the anatomy, current idiomatic modeling patterns in uberon, how we model spatial layers, how the proposed subdivision would relate to the capsule and the nucleus. Also show how this would relate to FMA terms. Compare also to standard anatomical diagrams etc Show (just in this PR comment, don't touch this actual PR) your proposed obo stanzas for these terms |
|
🤖 Working on it... Follow along: View workflow run |
Lens cortex zone subdivision: anatomical analysis and proposed modelingThis is an analysis-only comment — no changes are being made to this PR. The proposed stanzas below are for discussion; if accepted I would file them as a follow-up to refine what is already in this branch. 1. Anatomy: what the inner/outer cortex actually areThe human lens is an avascular, concentrically zoned, biconvex structure. Looking at the Vanderbilt Schey lab diagram you linked, the canonical onion-like topology from outside in is:
The cortex/nucleus boundary in life is a continuous gradient of cellular age, but it is reliably visible as an optical discontinuity by Scheimpflug/slit-lamp and is the standard partition used in MS imaging, AQP0/membrane-remodelling studies, and nutrient distribution studies (Yeum et al. 1999, PMID:10550792 explicitly compares "epithelium/outer cortex" vs "inner cortex/nucleus"). 2. How UBERON currently models lens spatial layersExisting pattern (today, on master): So the established UBERON idiom for the lens layers is the Comparable idiomatic patterns elsewhere in UBERON for concentric / inner-vs-outer subdivisions:
The existing lens-specific idiom is therefore richer than what is currently proposed in this PR — it uses both 3. How this maps to FMAFMA has all of this already, with a fuller mereological/topological decomposition (queried via OLS4 on FMA):
Two important consequences of the FMA picture:
4. Issues with the current PR as draftedCross-referenced against the analysis above, the current template rows have:
5. Proposed OBO stanzasThese are what I would propose the generated OBO should look like. They retain the HRA 6. What this buys us
7. Open questionFMA also has a finer partition ( If you'd like, I can open a follow-up PR with these refinements on top of this branch once it's merged, or fold them in directly here if you'd prefer to ship one cleaner PR. 🤖 Generated by @dragon-ai-agent
|
Generated via bulk_ntr_workflow from bulk_ntr_workflow/eye.csv (HRA ASCTB unmapped terms, eye table).
New terms:
Both classified as is_a UBERON:0034944 (zone of organ), following the pattern of lens nucleus (UBERON:0000390). Definitions reference PMID:10550792 and PMID:20171212.
Source labels 'Inner cortex' / 'Outer cortex' were renamed for disambiguation (see src/templates/hra-eye-reports/name_corrections.tsv); curator may add the originals as narrow synonyms.
Stage 5 registered hra_eye.owl as a template-driven component in uberon-odk.yaml and added the corresponding import to uberon-edit.obo. The empty groups template was removed (no group terms in this batch).
Note: 'sh run.sh make update_repo' was not run (Docker unavailable); component OWL will be generated on next ODK build.