Fixes #3640 Update eyelid textual definition #3641
Conversation
Fixes #3640 to correctly classify eyelid as a facial skin
|
#gogoeditdiff |
aleixpuigb
changed the title
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix issue #3640 by reclassifying the eyelid from "organ part" to "zone of skin". However, this change is semantically incorrect based on the anatomical composition of the eyelid and established ontology patterns.
Key Changes:
- Changed the parent classification of eyelid (UBERON:0001711) from "organ part" (UBERON:0000064) to "zone of skin" (UBERON:0000014)
aleixpuigb
changed the title
- Changed is_a from organ part to external soft tissue zone (UBERON:0034929) - Added has_part relationships for skin of eyelid and palpebral conjunctiva - Follows pattern established by prepuce for multi-tissue surface structures - Addresses feedback on PR #3641 about semantic classification @dragon-ai-agent Co-authored-by: dosumis <112839+dosumis@users.noreply.github.com>
|
Looks great but we need to be careful about species specificity - see https://chatgpt.com/share/695be87e-5674-800f-8d22-1862ee3c772e Maybe have a general term eyelid for vertebrates and keep this one for mammals, but indicate parenthetically bits that only apply to humans or primates. Potential general term: Edits to this term def: A movable anterior covering of the eye composed of skin, muscle, dense connective tissue (tarsal plate in humans, primates) with embedded meibomian glands, and palpebral conjunctiva; functions to protect the eyeball, distribute the tear film, and maintain the eyelash margin where this is present (humans, primates and some carnivores).
|
|
I have made the term general for any species with eyelids. I am not sure if we need a specific term for mammals/humans. |
|
We need to merge #3652 first to solve the problems. |
Fixes #3640
The eyelid is a composite anatomical structure that is not solely composed by skin. This PR updates the definition to reflect this and provides a dbxref: