Skip to content

Conversation

@cmungall
Copy link
Member

@cmungall cmungall commented Sep 23, 2024

@cmungall cmungall requested a review from dosumis October 17, 2024 21:20
@cmungall
Copy link
Member Author

cmungall commented Oct 17, 2024

Unsatisfiable - Joeys are not substances

image

@cmungall cmungall mentioned this pull request Oct 17, 2024
2 tasks
@cmungall
Copy link
Member Author

This is turning out to be harder than I expected

@gouttegd
Copy link
Collaborator

gouttegd commented Oct 18, 2024

Unsatisfiable - Joeys are not substances

We have encountered this one before, and it was agreed that the

'median vaginal canal' SubClassOf: 'channel for' some embryo

axiom should be removed, but then there was no follow-up…

Edit: My bad, I’ve just seen that you did exactly that in the subsequent commit. Sorry for the noise.

@gouttegd
Copy link
Collaborator

Regarding the last QC failure, I believe you have run into what should be considered a bug in the ODK. I have opened an issue with the details on the ODK repo.

A quick (but crude) workaround until the issue is fixed in the ODK would be to edit the standard Makefile to change the definition of $(SRCMERGED) from

SRCMERGED     = $(TMPDIR)/merged-$(SRC)

into

SRCMERGED     = $(TMPDIR)/merged-uberon-edit.ofn

to force the intermediate file on which the ROBOT report command is run to be written in OFN rather than OBO format, thereby avoiding OBO serialisation quirks.

@anitacaron anitacaron removed their request for review November 13, 2024 17:03
@github-actions
Copy link
Contributor

This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so.

@KrishnaTO
Copy link

commit 1a338fe resolves review in #3151

Copilot AI review requested due to automatic review settings January 13, 2026 21:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new high-level ontology term "gross anatomical part" (UBERON:0000001) to align with the Common Anatomy Reference Ontology (CARO) and COB standards. The term represents anatomical structures that are part of multicellular organisms at the gross anatomical level (above the cellular level).

Changes:

  • Added new term UBERON:0000001 (gross anatomical part) with definition, cross-references, and relationships
  • Reparented five existing terms to be children of the new gross anatomical part term instead of their previous parent terms
  • Removed one relationship from the median vaginal canal term (appears unrelated to the PR's stated purpose)

KrishnaTO added a commit to KrishnaTO/uberon that referenced this pull request Jan 13, 2026
KrishnaTO added a commit to KrishnaTO/uberon that referenced this pull request Jan 13, 2026
@matentzn
Copy link
Contributor

This was already added in COB with a COB id, I guess this PR complements it?

https://www.ebi.ac.uk/ols4/ontologies/cob/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FUBERON_0001062?lang=en

Changed the relationship from 'in_taxon' to 'present_in_taxon' for NCBITaxon:2759 (Eukaryota) in the uberon-edit.obo ontology file to reflect updated ontology standards.
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I note that the COB definition of the same term is slightly different

@cmungall cmungall merged commit 0ca2c6e into master Jan 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants