-
Notifications
You must be signed in to change notification settings - Fork 36
Adding gross anatomical part. Fixes #2921 #3374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Unsatisfiable - Joeys are not substances
|
|
This is turning out to be harder than I expected |
We have encountered this one before, and it was agreed that the
axiom should be removed, but then there was no follow-up… Edit: My bad, I’ve just seen that you did exactly that in the subsequent commit. Sorry for the noise. |
|
Regarding the last QC failure, I believe you have run into what should be considered a bug in the ODK. I have opened an issue with the details on the ODK repo. A quick (but crude) workaround until the issue is fixed in the ODK would be to edit the standard SRCMERGED = $(TMPDIR)/merged-$(SRC)into SRCMERGED = $(TMPDIR)/merged-uberon-edit.ofnto force the intermediate file on which the ROBOT |
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a new high-level ontology term "gross anatomical part" (UBERON:0000001) to align with the Common Anatomy Reference Ontology (CARO) and COB standards. The term represents anatomical structures that are part of multicellular organisms at the gross anatomical level (above the cellular level).
Changes:
- Added new term UBERON:0000001 (gross anatomical part) with definition, cross-references, and relationships
- Reparented five existing terms to be children of the new gross anatomical part term instead of their previous parent terms
- Removed one relationship from the median vaginal canal term (appears unrelated to the PR's stated purpose)
|
This was already added in COB with a COB id, I guess this PR complements it? |
Changed the relationship from 'in_taxon' to 'present_in_taxon' for NCBITaxon:2759 (Eukaryota) in the uberon-edit.obo ontology file to reflect updated ontology standards.
matentzn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I note that the COB definition of the same term is slightly different

To align with COB
See