Enterocyte refactor renaming by JABelfiore · Pull Request #2944 · obophenotype/cell-ontology

JABelfiore · 2025-02-10T16:47:49Z

No description provided.

enterocyte of epithelium of small intestine --> small intestine enterocyte early enterocyte --> early small intestine enterocyte.

dosumis · 2025-02-14T10:36:33Z

#gogoeditdiff

github-actions · 2025-02-14T10:42:26Z

Here's a diff of how these changes impact the classified ontology (on -base file):

Ontology comparison

Left

Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-03-12/cl-base.owl
Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-master.owl/cl-base.owl

Right

Ontology IRI: http://purl.obolibrary.org/obo/cl/cl-base.owl
Version IRI: http://purl.obolibrary.org/obo/cl/releases/2025-03-12/cl-base.owl
Loaded from: file:/__w/cell-ontology/cell-ontology/src/ontology/cl-base-pr.owl/cl-base.owl

Ontology imports

Ontology annotations

enterocyte `http://purl.obolibrary.org/obo/CL_0000584`

Removed

enterocyte IAO_0000115 "An epithelial cell that has its apical plasma membrane folded into microvilli to provide ample surface for the absorption of nutrients from the intestinal lumen."
- hasDbXref "SANBI:mhl"
enterocyte hasNarrowSynonym "differentiated enterocyte"
- hasDbXref "https://orcid.org/0000-0001-9610-7627"
- hasDbXref "PMID:33290721"

Added

enterocyte IAO_0000115 "An epithelial cell that has its apical plasma membrane folded into microvilli to provide ample surface for the absorption of nutrients from the intestinal lumen. This covers both the large and small intestine."
- hasDbXref "SANBI:mhl"

enterocyte of epithelium of intestinal villus `http://purl.obolibrary.org/obo/CL_1000335`

Added

enterocyte of epithelium of intestinal villus hasExactSynonym "late small intestine enterocyte"
enterocyte of epithelium of intestinal villus hasExactSynonym "mature small intestine enterocyte"

immature colonocyte `http://purl.obolibrary.org/obo/CL_4047018`

Removed

immature colonocyte label "early colonocyte"@en
immature colonocyte EquivalentTo immature small intestine enterocyte and (BFO_0000050 some UBERON_0000397)
immature colonocyte SubClassOf immature small intestine enterocyte

Added

immature colonocyte label "immature colonocyte"@en
immature colonocyte hasExactSynonym "early colonocyte"

immature small intestine enterocyte `http://purl.obolibrary.org/obo/CL_4047019`

Removed

immature small intestine enterocyte label "early enterocyte"@en

Added

immature small intestine enterocyte label "immature small intestine enterocyte"@en
immature small intestine enterocyte hasExactSynonym "early enterocyte"

immature small intestine entrocyte `http://purl.obolibrary.org/obo/CL_0008050`

Added

immature small intestine entrocyte label "immature small intestine entrocyte"
immature small intestine entrocyte date "2025-03-11T18:54:02Z"^^dateTime
immature small intestine entrocyte contributor 0000-0002-7073-9172
Class: immature small intestine entrocyte
immature small intestine entrocyte SubClassOf small intestine enterocyte

mature colonocyte `http://purl.obolibrary.org/obo/CL_0008052`

Added

mature colonocyte date "2025-03-11T18:55:58Z"^^dateTime
mature colonocyte label "mature colonocyte"
mature colonocyte contributor 0000-0002-7073-9172
Class: mature colonocyte
mature colonocyte SubClassOf colonocyte
mature colonocyte SubClassOf RO_0002207 some immature colonocyte

mature small intestince enterocyte `http://purl.obolibrary.org/obo/CL_0008051`

Added

mature small intestince enterocyte date "2025-03-11T18:54:17Z"^^dateTime
mature small intestince enterocyte label "mature small intestince enterocyte"
mature small intestince enterocyte contributor 0000-0002-7073-9172
Class: mature small intestince enterocyte
mature small intestince enterocyte SubClassOf RO_0002207 some immature small intestine enterocyte
mature small intestince enterocyte SubClassOf small intestine enterocyte

small intestine enterocyte `http://purl.obolibrary.org/obo/CL_1000334`

Removed

small intestine enterocyte label "enterocyte of epithelium of small intestine"

Added

small intestine enterocyte hasExactSynonym "enterocyte of epithelium of small intestine"
small intestine enterocyte label "small intestine enterocyte"

github-actions · 2025-02-14T10:42:28Z

Here's a diff of your edit file (unreasoned)

Ontology comparison

Left

Ontology IRI: http://purl.obolibrary.org/obo/cl-edit.owl
Version IRI: None
Loaded from: file:/__w/cell-ontology/cell-ontology/master/src/ontology/cl-edit.owl

Right

Ontology IRI: http://purl.obolibrary.org/obo/cl-edit.owl
Version IRI: None
Loaded from: file:/__w/cell-ontology/cell-ontology/branch/src/ontology/cl-edit.owl

Ontology imports

Ontology annotations

early colonocyte `http://purl.obolibrary.org/obo/CL_4047018`

Removed

early colonocyte label "early colonocyte"@en
early colonocyte EquivalentTo early enterocyte and (part of some colonic epithelium)

Added

early colonocyte label "immature colonocyte"@en
early colonocyte has_exact_synonym "early colonocyte"
early colonocyte SubClassOf colonocyte

early enterocyte `http://purl.obolibrary.org/obo/CL_4047019`

Removed

early enterocyte label "early enterocyte"@en

Added

early enterocyte label "immature small intestine enterocyte"@en
early enterocyte has_exact_synonym "early enterocyte"

enterocyte `http://purl.obolibrary.org/obo/CL_0000584`

Removed

enterocyte definition "An epithelial cell that has its apical plasma membrane folded into microvilli to provide ample surface for the absorption of nutrients from the intestinal lumen."
- database_cross_reference "SANBI:mhl"
enterocyte has_narrow_synonym "differentiated enterocyte"
- database_cross_reference "https://orcid.org/0000-0001-9610-7627"
- database_cross_reference "PMID:33290721"

Added

enterocyte definition "An epithelial cell that has its apical plasma membrane folded into microvilli to provide ample surface for the absorption of nutrients from the intestinal lumen. This covers both the large and small intestine."
- database_cross_reference "SANBI:mhl"

enterocyte of epithelium of intestinal villus `http://purl.obolibrary.org/obo/CL_1000335`

Added

enterocyte of epithelium of intestinal villus has_exact_synonym "late small intestine enterocyte"
enterocyte of epithelium of intestinal villus has_exact_synonym "mature small intestine enterocyte"

enterocyte of epithelium of small intestine `http://purl.obolibrary.org/obo/CL_1000334`

Removed

enterocyte of epithelium of small intestine label "enterocyte of epithelium of small intestine"

Added

enterocyte of epithelium of small intestine has_exact_synonym "enterocyte of epithelium of small intestine"
enterocyte of epithelium of small intestine label "small intestine enterocyte"

immature small intestine entrocyte `http://purl.obolibrary.org/obo/CL_0008050`

Added

immature small intestine entrocyte label "immature small intestine entrocyte"
immature small intestine entrocyte date "2025-03-11T18:54:02Z"^^dateTime
immature small intestine entrocyte contributor 0000-0002-7073-9172
Class: immature small intestine entrocyte
immature small intestine entrocyte SubClassOf enterocyte of epithelium of small intestine

mature colonocyte `http://purl.obolibrary.org/obo/CL_0008052`

Added

mature colonocyte date "2025-03-11T18:55:58Z"^^dateTime
mature colonocyte label "mature colonocyte"
mature colonocyte contributor 0000-0002-7073-9172
Class: mature colonocyte
mature colonocyte SubClassOf colonocyte
mature colonocyte SubClassOf directly develops from some early colonocyte

mature small intestince enterocyte `http://purl.obolibrary.org/obo/CL_0008051`

Added

mature small intestince enterocyte date "2025-03-11T18:54:17Z"^^dateTime
mature small intestince enterocyte label "mature small intestince enterocyte"
mature small intestince enterocyte contributor 0000-0002-7073-9172
Class: mature small intestince enterocyte
mature small intestince enterocyte SubClassOf directly develops from some early enterocyte
mature small intestince enterocyte SubClassOf enterocyte of epithelium of small intestine

- [x] Make sure early is not part of standard/mature - [x] Get rid of differentiated enterocyte from synonyms - [x] Mature and immature to be used instead of early and late

QUick attempt at fix. Needs review to see if any more earlier changes need reverting.

dosumis · 2025-03-12T11:50:00Z

#gogoeditdiff

github-actions · 2025-03-12T11:51:22Z

Your branch is 3 commit/s behind, please update your branch.

dosumis · 2025-03-12T12:05:32Z

#gogoeditdiff

dosumis · 2025-04-02T10:31:12Z

Remaining issues:

General definition of enterocyte refers to mature state. Ditto colonocyte.
Defs needed for mature colonocyte + immature and mature small intestine enterocyte
EC def of immature small intestine enterocyte is dubious
Species neutral terminology: Can we make enterocyte neutral, or should we aim to use 'gut absorptive cell'? A: making either species neutral requires deleting taxon restriction on mucosa to chordata (in Uberon). Suggest push to second ticket.

JABelfiore added 2 commits January 20, 2025 15:29

enterocyte renaming

16086a5

enterocyte of epithelium of small intestine --> small intestine enterocyte early enterocyte --> early small intestine enterocyte.

Merge branch 'master' into 2882-enterocyte-refactor-renaming

ec6871d

JABelfiore requested a review from dosumis February 10, 2025 16:47

JABelfiore self-assigned this Feb 10, 2025

JABelfiore linked an issue Feb 10, 2025 that may be closed by this pull request

Enterocyte refactor & renaming #2882

Open

JABelfiore changed the title ~~2882 enterocyte refactor renaming~~ Enterocyte refactor renaming Feb 10, 2025

JABelfiore and others added 3 commits February 11, 2025 12:18

Merge branch 'master' into 2882-enterocyte-refactor-renaming

030472a

Merge branch 'master' into 2882-enterocyte-refactor-renaming

d4b3b38

Merge branch 'master' into 2882-enterocyte-refactor-renaming

019b253

JABelfiore and others added 8 commits February 18, 2025 10:52

Merge branch 'master' into 2882-enterocyte-refactor-renaming

6c9a471

Merge branch 'master' into 2882-enterocyte-refactor-renaming

f2da425

Merge branch 'master' into 2882-enterocyte-refactor-renaming

bc13dd8

Merge branch 'master' into 2882-enterocyte-refactor-renaming

0e33aa4

Merge branch 'master' into 2882-enterocyte-refactor-renaming

a4ef85e

Update cl-edit.owl

017dd70

- [x] Make sure early is not part of standard/mature - [x] Get rid of differentiated enterocyte from synonyms - [x] Mature and immature to be used instead of early and late

refactoring

8ad3ddd

Update cl-edit.owl

5d3aa57

QUick attempt at fix. Needs review to see if any more earlier changes need reverting.

Merge branch 'master' into 2882-enterocyte-refactor-renaming

30f5b46

dosumis marked this pull request as draft March 12, 2025 12:21

Conversation

JABelfiore commented Feb 10, 2025

Uh oh!

dosumis commented Feb 14, 2025

Uh oh!

github-actions bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ontology comparison

Left

Right

Ontology imports

Ontology annotations

enterocyte http://purl.obolibrary.org/obo/CL_0000584

Removed

Added

enterocyte of epithelium of intestinal villus http://purl.obolibrary.org/obo/CL_1000335

Added

immature colonocyte http://purl.obolibrary.org/obo/CL_4047018

Removed

Added

immature small intestine enterocyte http://purl.obolibrary.org/obo/CL_4047019

Removed

Added

immature small intestine entrocyte http://purl.obolibrary.org/obo/CL_0008050

Added

mature colonocyte http://purl.obolibrary.org/obo/CL_0008052

Added

mature small intestince enterocyte http://purl.obolibrary.org/obo/CL_0008051

Added

small intestine enterocyte http://purl.obolibrary.org/obo/CL_1000334

Removed

Added

Uh oh!

github-actions bot commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ontology comparison

Left

Right

Ontology imports

Ontology annotations

early colonocyte http://purl.obolibrary.org/obo/CL_4047018

Removed

Added

early enterocyte http://purl.obolibrary.org/obo/CL_4047019

Removed

Added

enterocyte http://purl.obolibrary.org/obo/CL_0000584

Removed

Added

enterocyte of epithelium of intestinal villus http://purl.obolibrary.org/obo/CL_1000335

Added

enterocyte of epithelium of small intestine http://purl.obolibrary.org/obo/CL_1000334

Removed

Added

immature small intestine entrocyte http://purl.obolibrary.org/obo/CL_0008050

Added

mature colonocyte http://purl.obolibrary.org/obo/CL_0008052

Added

mature small intestince enterocyte http://purl.obolibrary.org/obo/CL_0008051

Added

Uh oh!

dosumis commented Mar 12, 2025

Uh oh!

github-actions bot commented Mar 12, 2025

Uh oh!

dosumis commented Mar 12, 2025

Uh oh!

dosumis commented Apr 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Feb 14, 2025 •

edited

Loading

enterocyte `http://purl.obolibrary.org/obo/CL_0000584`

enterocyte of epithelium of intestinal villus `http://purl.obolibrary.org/obo/CL_1000335`

immature colonocyte `http://purl.obolibrary.org/obo/CL_4047018`

immature small intestine enterocyte `http://purl.obolibrary.org/obo/CL_4047019`

immature small intestine entrocyte `http://purl.obolibrary.org/obo/CL_0008050`

mature colonocyte `http://purl.obolibrary.org/obo/CL_0008052`

mature small intestince enterocyte `http://purl.obolibrary.org/obo/CL_0008051`

small intestine enterocyte `http://purl.obolibrary.org/obo/CL_1000334`

github-actions bot commented Feb 14, 2025 •

edited

Loading

early colonocyte `http://purl.obolibrary.org/obo/CL_4047018`

early enterocyte `http://purl.obolibrary.org/obo/CL_4047019`

enterocyte `http://purl.obolibrary.org/obo/CL_0000584`

enterocyte of epithelium of intestinal villus `http://purl.obolibrary.org/obo/CL_1000335`

enterocyte of epithelium of small intestine `http://purl.obolibrary.org/obo/CL_1000334`

immature small intestine entrocyte `http://purl.obolibrary.org/obo/CL_0008050`

mature colonocyte `http://purl.obolibrary.org/obo/CL_0008052`

mature small intestince enterocyte `http://purl.obolibrary.org/obo/CL_0008051`