fix: content is not displayed if collaped default to true#480
Open
truph01 wants to merge 1 commit intooblador:masterfrom
Open
fix: content is not displayed if collaped default to true#480truph01 wants to merge 1 commit intooblador:masterfrom
truph01 wants to merge 1 commit intooblador:masterfrom
Conversation
Pujan92
reviewed
Sep 17, 2024
|
|
||
| componentDidMount() { | ||
| if (!this.props.collapsed) { | ||
| this._toggleCollapsed(this.props.collapsed); |
There was a problem hiding this comment.
Suggested change
| this._toggleCollapsed(this.props.collapsed); | |
| this._measureContent((height) => this.state.height.setValue(height)); |
Just sharing other option in case we don't want to show the animation transition initially.
cc: @oblador
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-17.at.22.03.32.mp4
|
@oblador can you please merge this fix and release newer version? |
|
@oblador merging this can potentially close two of the GitHub issues for this package. When can you get to this please? |
|
August 2025 and still no merge here... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix the issue content is not displayed if collapsed is true in #479
Here is the result after the fix:
Android:
Screen.Recording.2024-09-17.at.09.24.11.mov
Ios:
Screen.Recording.2024-09-17.at.09.24.24.mov