only use a fixed/calculated height during animation#272
Open
DaKaZ wants to merge 3 commits intooblador:masterfrom
Open
only use a fixed/calculated height during animation#272DaKaZ wants to merge 3 commits intooblador:masterfrom
DaKaZ wants to merge 3 commits intooblador:masterfrom
Conversation
Collaborator
|
Do you have an example of this not working? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure if its my content, an issue of timing of when the measurement is taken, or just a bug in this or core react-native, but the measured size for my content is ALWAYS wrong. The measured height is between 10 and 28 pixels too large. I have fought with this for a while but I found that if I REMOVE the explicit height (all my content is in flex boxes and does include some SVG component) it works perfectly. Seeing that height is used for the animating process, I made this small PR to only apply height during the animating. It should not (as far as I can tell) change the components default behavior so I am hoping this will be accepted.