Skip to content

Minor fix #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timweri merged 1 commit into from
Apr 30, 2026
Merged

Minor fix #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/yubikey/piv/management.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@ impl CSRSigner {
/// Create a new certificate signer based on a Yubikey serial
/// and slot
pub fn new(serial: u32, slot: SlotId) -> Result<Self> {
let mut yk = super::Yubikey::open(serial)
.map_err(|e| Error::InternalYubiKeyError(e.to_string()))?;
let mut yk = super::Yubikey::open(serial)?;
let cert = yk.configured(&slot)
.map_err(|e| Error::InternalYubiKeyError(format!("failed to read certificate for CSR generation: {}", e)))?;
let pki = cert.subject_pki();
Expand Down Expand Up @@ -333,7 +332,7 @@ impl super::Yubikey {
/// is empty) this will error.
pub fn sign_data(&mut self, data: &[u8], alg: AlgorithmId, slot: &SlotId) -> Result<Vec<u8>> {
let cert = self.configured(&slot)
.map_err(|e| Error::InternalYubiKeyError(format!("failed to read certificate for CSR generation: {}", e)))?;
.map_err(|e| Error::InternalYubiKeyError(format!("failed to read slot for signing: {}", e)))?;
let pki = cert.subject_pki();
let oid_alg = pki
.algorithm
Expand Down
Loading