Skip to content

Conversation

@dfries
Copy link

@dfries dfries commented Oct 11, 2015

Fixed comment typos and macro #if tests that g++ was complaining about, it complains if SOMETHING isn't defined such as '#if SOMETHING'

v-usb has been working on my project and I haven't had any USB problems.

warning: "__CODEVISIONAVR__" is not defined
Check to see if it is defined, instead of using the value of a
potentially undefined definition.
@lod lod mentioned this pull request Oct 21, 2016
@starkjohann
Copy link
Contributor

I don't want to merge the warning fix as is, because the documentation for USB_CFG_HID_REPORT_DESCRIPTOR_LENGTH states "Otherwise don't define it or define it to 0". The #if defined would count 0 as defined, too.

Would the warning go away if we put an extern "C" around the entire header, not just the includes at the top?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants