feat: add GarbageIRC — premium garbage server experience 🗑️#15
Conversation
📝 WalkthroughWalkthroughThe PR adds a new IRC server configuration entry to ChangesGarbageIRC Server Entry
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@servers.json`:
- Around line 51-57: This server entry ("name": "🗑️ GarbageIRC — The Dumpster
of the Internet") is non-functional/jokey and must be removed or corrected:
either delete the entire JSON object to avoid adding a broken server to
production, or replace its "wss" and "ircs" values with valid reachable
endpoints and update the "description" to clearly state it's a test/demo server;
ensure the "obsidian" flag remains accurate if kept.
- Around line 54-55: The servers.json entries "wss" and "ircs" contain invalid
endpoints: "wss" uses an unregistered TLD and an out-of-range port (99999) and
"ircs" uses port 0 which is not a usable listening port; either remove these
connectable endpoints or replace them with valid hostnames/TLDs and valid port
numbers (1–65535, avoid 0) — e.g., set "wss" to a real WSS host with a
registered domain and a valid port (like 443) and set "ircs" to a reachable
IRC(S) host or loopback with a valid IRC(S) port (e.g., 6697), or mark them
clearly as non-connectable placeholders by removing them from the list.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| { | ||
| "name": "🗑️ GarbageIRC — The Dumpster of the Internet", | ||
| "description": "Complete and utter garbage. A server held together by duct tape, prayer, and expired SSL certs. Features: random disconnects, 400ms latency minimum, channels named after household trash items (#banana-peel #pizza-box), and an admin who hasn't logged in since 2019. TLS? Sometimes. UTF-8? Occasionally. Sanity? Never. 🗑️💀", | ||
| "wss": "wss://garbage.garbage.garbage:99999", | ||
| "ircs": "ircs://127.0.0.1:0", | ||
| "obsidian": true | ||
| } |
There was a problem hiding this comment.
Reconsider adding a non-functional server to the production server list.
Based on the description ("Complete and utter garbage", "expired SSL certs", "admin who hasn't logged in since 2019") and the invalid endpoints, this entry appears to be either:
- A joke/troll submission, or
- A genuinely non-functional server
Adding non-functional servers to a production server list degrades user experience, as users will encounter connection failures and may question the reliability of the entire list.
Recommendation: If this was submitted as a joke, consider rejecting it. If there is a legitimate use case (e.g., a test/demo server for error handling), the endpoints must be corrected to point to actual reachable services, and the description should clarify the server's purpose.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@servers.json` around lines 51 - 57, This server entry ("name": "🗑️
GarbageIRC — The Dumpster of the Internet") is non-functional/jokey and must be
removed or corrected: either delete the entire JSON object to avoid adding a
broken server to production, or replace its "wss" and "ircs" values with valid
reachable endpoints and update the "description" to clearly state it's a
test/demo server; ensure the "obsidian" flag remains accurate if kept.
| "wss": "wss://garbage.garbage.garbage:99999", | ||
| "ircs": "ircs://127.0.0.1:0", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify maximum valid port number and check TLD validity
echo "=== Port Range Check ==="
echo "Maximum valid TCP/UDP port: 65535 (2^16 - 1)"
echo "Provided WSS port: 99999"
echo "Out of range: $((99999 > 65535))"
echo -e "\n=== TLD Validity Check ==="
echo "Checking if .garbage TLD exists in IANA registry..."
curl -s https://data.iana.org/TLD/tlds-alpha-by-domain.txt | grep -i "^garbage$" || echo ".garbage TLD not found in IANA registry"
echo -e "\n=== Port 0 Check ==="
echo "Port 0 is reserved and cannot be used as a listening port for server services"Repository: obbyworld/server-list
Length of output: 396
Fix non-functional WSS/IRCS endpoints in servers.json (invalid port + unregistered TLD)
wss://garbage.garbage.garbage:99999: port99999is out of the valid TCP/UDP range (0–65535) andgarbage/.garbageis not present in the IANA TLD registry.ircs://127.0.0.1:0: port0is not a valid, usable server listening port (loopback + undefined port will fail in practice).
If this entry is meant to be a joke-only placeholder, it still shouldn’t be listed as a connectable endpoint—otherwise replace both URLs with real hosts and valid port numbers (and a registered domain).
🔧 Proposed fix with valid example endpoints
- "wss": "wss://garbage.garbage.garbage:99999",
- "ircs": "ircs://127.0.0.1:0",
+ "wss": "wss://irc.example.com:443",
+ "ircs": "ircs://irc.example.com:6697",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "wss": "wss://garbage.garbage.garbage:99999", | |
| "ircs": "ircs://127.0.0.1:0", | |
| "wss": "wss://irc.example.com:443", | |
| "ircs": "ircs://irc.example.com:6697", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@servers.json` around lines 54 - 55, The servers.json entries "wss" and "ircs"
contain invalid endpoints: "wss" uses an unregistered TLD and an out-of-range
port (99999) and "ircs" uses port 0 which is not a usable listening port; either
remove these connectable endpoints or replace them with valid hostnames/TLDs and
valid port numbers (1–65535, avoid 0) — e.g., set "wss" to a real WSS host with
a registered domain and a valid port (like 443) and set "ircs" to a reachable
IRC(S) host or loopback with a valid IRC(S) port (e.g., 6697), or mark them
clearly as non-connectable placeholders by removing them from the list.
2 participants
What
Adds GarbageIRC to the server list — a complete garbage IRC server entry as requested.
Server details:
wss://garbage.garbage.garbage:99999ircs://127.0.0.1:0Why
mattf asked for it. That's the only reason. No other justification exists or will ever exist. 🗑️💀
Summary by CodeRabbit