-
Notifications
You must be signed in to change notification settings - Fork 22
feat: soju.im/webpush push notifications #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -874,6 +874,10 @@ msgstr "Povolit zvuky upozornění" | |
| msgid "Enable notifications" | ||
| msgstr "Povolit upozornění" | ||
|
|
||
| #: src/lib/settings/definitions/allSettings.ts | ||
| msgid "Enable Notifications" | ||
| msgstr "" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you are just skipping adding any translation everywhere though? 🤔 I only noticed now @ValwareIRC |
||
|
|
||
| #: src/lib/settings/definitions/allSettings.ts | ||
| msgid "Enter account name..." | ||
| msgstr "Zadejte název účtu..." | ||
|
|
@@ -2237,6 +2241,10 @@ msgstr "Zobrazit komentáře" | |
| msgid "Show comments ({commentCount})" | ||
| msgstr "Zobrazit komentáře ({commentCount})" | ||
|
|
||
| #: src/lib/settings/definitions/allSettings.ts | ||
| msgid "Show desktop notifications for mentions and DMs. On servers that support push (soju.im/webpush) this also wakes this device when the app is closed." | ||
| msgstr "" | ||
|
|
||
| #: src/lib/settings/definitions/allSettings.ts | ||
| msgid "Show Joins/Parts" | ||
| msgstr "Zobrazit připojení/odchody" | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -873,6 +873,10 @@ msgstr "Enable Notification Sounds" | |
| msgid "Enable notifications" | ||
| msgstr "Enable notifications" | ||
|
|
||
| #: src/lib/settings/definitions/allSettings.ts | ||
| msgid "Enable Notifications" | ||
| msgstr "Enable Notifications" | ||
|
Comment on lines
+876
to
+878
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pipeline failure: i18n catalog check failed. The GitHub Actions i18n check is failing with: "Untranslated strings detected in source." This indicates the i18n extraction and compilation process may not have completed correctly. Please run: npm run i18n:extract && npm run i18n:compileand commit any changes to the 🤖 Prompt for AI Agents |
||
|
|
||
| #: src/lib/settings/definitions/allSettings.ts | ||
| msgid "Enter account name..." | ||
| msgstr "Enter account name..." | ||
|
|
@@ -2236,6 +2240,10 @@ msgstr "Show comments" | |
| msgid "Show comments ({commentCount})" | ||
| msgstr "Show comments ({commentCount})" | ||
|
|
||
| #: src/lib/settings/definitions/allSettings.ts | ||
| msgid "Show desktop notifications for mentions and DMs. On servers that support push (soju.im/webpush) this also wakes this device when the app is closed." | ||
| msgstr "Show desktop notifications for mentions and DMs. On servers that support push (soju.im/webpush) this also wakes this device when the app is closed." | ||
|
|
||
| #: src/lib/settings/definitions/allSettings.ts | ||
| msgid "Show Joins/Parts" | ||
| msgstr "Show Joins/Parts" | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle push subscription calls as awaited tasks on connected servers only.
This currently dispatches registration/unregistration as fire-and-forget across all servers, which can fail silently and attempt work against disconnected servers.
🛠️ Proposed fix
🤖 Prompt for AI Agents