Skip to content

fix(channel-settings): recognise ObbyIRCd in the UnrealIRCd-detection check#195

Closed
ValwareIRC wants to merge 1 commit into
mainfrom
fix/obbyircd-channel-settings-tabs
Closed

fix(channel-settings): recognise ObbyIRCd in the UnrealIRCd-detection check#195
ValwareIRC wants to merge 1 commit into
mainfrom
fix/obbyircd-channel-settings-tabs

Conversation

@ValwareIRC
Copy link
Copy Markdown
Contributor

@ValwareIRC ValwareIRC commented May 7, 2026

Summary

The Channel Settings modal's "Advanced" tab is gated on
server.isUnrealIRCd, which gets set by string-matching the
RPL_YOURHOST (002) version. The check was an exact match for
`UnrealIRCd`. ObbyIRCd is a downstream fork that puts its own name
(`ObbyIRCd-6.2.5-git`) in 002, so the gate stayed false and channel
ops on ObbyIRCd networks lost access to the Advanced tab even though
the underlying chanmode surface is the same.

One-liner: include `ObbyIRCd` alongside `UnrealIRCd` in the
version-string match in src/store/handlers/channels.ts.

The comment also calls out that ObbyIRCd-only features (e.g. named-modes,
which UnrealIRCd doesn't have) are detected via their own caps and should
NOT be conflated with the UnrealIRCd-parity flag.

Test plan

  • CI green
  • Manual: connect to obby.t3ks.com (ObbyIRCd), open Channel Settings as
    a chanop, confirm "Advanced" tab shows alongside "Settings"/"General".
  • Manual: connect to a vanilla UnrealIRCd, confirm Advanced still shows.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced server type detection to recognize ObbyIRCd servers alongside UnrealIRCd, ensuring both server types now have access to appropriate UI features and functionality.

… check

The "Advanced" tab in ChannelSettingsModal is gated on
`server.isUnrealIRCd`, which was set by exact-matching "UnrealIRCd" in
the RPL_YOURHOST (002) version string. ObbyIRCd is a downstream
UnrealIRCd fork that advertises its own name there ("ObbyIRCd-..."),
so the gate stayed false and channel ops on ObbyIRCd networks lost
the Advanced tab even though the underlying chanmode surface is the
same.

Match either name. Comment also clarifies that ObbyIRCd-only features
(e.g. named-modes) are detected via their own caps and should NOT be
conflated with the UnrealIRCd-parity flag.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bd9f2f57-30a1-4f5d-91bc-2c625a64b279

📥 Commits

Reviewing files that changed from the base of the PR and between 58799eb and d26418c.

📒 Files selected for processing (1)
  • src/store/handlers/channels.ts

📝 Walkthrough

Walkthrough

The change expands the server version detection logic in registerChannelHandlers to recognize both UnrealIRCd and ObbyIRCd server types when setting the isUnrealIRCd UI gating flag. Previously only UnrealIRCd was detected; the updated condition now matches either variant.

Changes

Server Version Detection

Layer / File(s) Summary
Version Check Logic
src/store/handlers/channels.ts
The isUnrealIRCd flag is set when the server version string includes either UnrealIRCd or ObbyIRCd, broadening the single-server-type check to support both variants.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • matheusfillipe

Poem

🐰 A version check grows wise and wide,
Now ObbyIRCd stands side by side,
With UnrealIRCd in the code's embrace,
Both flags shine bright in their rightful place! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/obbyircd-channel-settings-tabs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ValwareIRC ValwareIRC closed this May 7, 2026
@ValwareIRC ValwareIRC deleted the fix/obbyircd-channel-settings-tabs branch May 7, 2026 15:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Pages Preview
Preview URL: https://fix-obbyircd-channel-setting.obsidianirc.pages.dev

Automated deployment preview for the PR in the Cloudflare Pages.

@ValwareIRC
Copy link
Copy Markdown
Contributor Author

Misplaced — closed. Fix is now on feat/named-modes (commit 343c7bf in PR #194), where the next step migrates these tabs to use sendNamedMode/PROP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant