fix(channel-settings): recognise ObbyIRCd in the UnrealIRCd-detection check#195
fix(channel-settings): recognise ObbyIRCd in the UnrealIRCd-detection check#195ValwareIRC wants to merge 1 commit into
Conversation
… check
The "Advanced" tab in ChannelSettingsModal is gated on
`server.isUnrealIRCd`, which was set by exact-matching "UnrealIRCd" in
the RPL_YOURHOST (002) version string. ObbyIRCd is a downstream
UnrealIRCd fork that advertises its own name there ("ObbyIRCd-..."),
so the gate stayed false and channel ops on ObbyIRCd networks lost
the Advanced tab even though the underlying chanmode surface is the
same.
Match either name. Comment also clarifies that ObbyIRCd-only features
(e.g. named-modes) are detected via their own caps and should NOT be
conflated with the UnrealIRCd-parity flag.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change expands the server version detection logic in ChangesServer Version Detection
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Automated deployment preview for the PR in the Cloudflare Pages. |
Summary
The Channel Settings modal's "Advanced" tab is gated on
server.isUnrealIRCd, which gets set by string-matching theRPL_YOURHOST (002) version. The check was an exact match for
`UnrealIRCd`. ObbyIRCd is a downstream fork that puts its own name
(`ObbyIRCd-6.2.5-git`) in 002, so the gate stayed false and channel
ops on ObbyIRCd networks lost access to the Advanced tab even though
the underlying chanmode surface is the same.
One-liner: include `ObbyIRCd` alongside `UnrealIRCd` in the
version-string match in src/store/handlers/channels.ts.
The comment also calls out that ObbyIRCd-only features (e.g. named-modes,
which UnrealIRCd doesn't have) are detected via their own caps and should
NOT be conflated with the UnrealIRCd-parity flag.
Test plan
a chanop, confirm "Advanced" tab shows alongside "Settings"/"General".
Summary by CodeRabbit