refactor: add socket factory seam under IRC transport#177
Conversation
Keep the existing default TCP/TLS and WebSocket routing unchanged, but expose an injectable socket factory so alternate transports can be integrated and tested without rewriting IRC client logic.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 48 minutes and 17 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR opens a narrow transport seam under ObsidianIRC's existing socket layer without changing default behavior.
What changes
wss://->WebSocketWrapperirc:///ircs://->TCPSocketSocketFactoryWhy
ObsidianIRC already has protocol selection, but the routing was still effectively hardcoded.
An injectable seam makes future transport experimentation and testing cleaner while preserving current behavior.
This mirrors the same direction already applied in the related tobby refactor, but fits ObsidianIRC's existing architecture where WebSocket support already exists.
Verification
npm run formatnpm run fix:unsafenpm run testnpm run buildNotes
The full test suite passes, though the repository already emits pre-existing jsdom/React test warnings around
HTMLMediaElement.prototype.pauseand someact(...)coverage in unrelated tests.