-
Notifications
You must be signed in to change notification settings - Fork 146
setuptools compliancy #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Doesn't work with Python 3: Work fine with Python 2: |
|
if you modify oandapy/init.py --- a/oandapy/init.py it is solved |
|
It helped. Will you create another PR? |
|
I've made the change and pushed it. It is in the pending pull request I |
|
I have written some tests to test the complete API. Tests pass Python |
|
Why don't you split your changes into multiple branches/PRs ? Putting it all under name of "Update of README" is a bit misinforming. |
|
Yes you are right and I've noticed it too. Therefore I've already made a |
|
Good luck. I hope they will accept your changes/improvements. They're not very good at this. As if no one at OANDA cares about API anymore. |
make the oandapy setuptools compliant. This makes it pip installable. Optionally the package could be put on pypi.python.org
versioning up to OANDA, I guess semantic versioning MAJOR.MINOR.PATCH would be the way to go.
Please, see request #9 and #20 also.
After this change installing and upgrading comes down to:
pip install git+https://github.com/oanda/oandapy
a pypi package would even be more convenient:
pip install oandapy