Skip to content

Comments

Sdk 52#27

Merged
lucasvinhas merged 3 commits intodevelopfrom
SDK-54
Feb 20, 2026
Merged

Sdk 52#27
lucasvinhas merged 3 commits intodevelopfrom
SDK-54

Conversation

@lucasvinhas
Copy link
Contributor

No description provided.

…tion tests

- Updated VSCode settings to support on-demand Jest runs with virtual folders for API and contracts.
- Expanded the sample environment file to include payment-related configuration variables.
- Implemented integration tests for the payment service, covering both PagarMe and Stripe payment requests.
- Added a script to ensure exact test runs with Jest, improving test execution accuracy.
@lucasvinhas lucasvinhas changed the base branch from main to develop February 20, 2026 13:51
@lucasvinhas lucasvinhas changed the title Sdk 54 Sdk 52 Feb 20, 2026
Copy link

@fahmidareem3 fahmidareem3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fef3f47a82

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link

@fahmidareem3 fahmidareem3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes requested. Good PR!

@tahseen-ccprotocol
Copy link
Contributor

Could you please take a look into the already merged integration test? It currently doesn’t look consistent with the others and feels a bit messy. If we follow the same pattern across all tests, it will be easier to maintain and extend them in the future.

…configuration

- Removed obsolete payment-related variables from the sample environment file.
- Simplified payment service integration tests by eliminating unnecessary code and focusing on essential functionality.
…stomer retrieval and timeout settings

- Added a timeout constant for integration tests to ensure consistent execution duration.
- Updated the logic for finding an approved customer, simplifying the retrieval process and improving test reliability.
- Enhanced error handling and logging for scenarios where no approved customers are found.
- Refactored test cases for clarity and consistency, ensuring they adhere to the new timeout settings.
@lucasvinhas lucasvinhas merged commit d498a7a into develop Feb 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants