Conversation
…tion tests - Updated VSCode settings to support on-demand Jest runs with virtual folders for API and contracts. - Expanded the sample environment file to include payment-related configuration variables. - Implemented integration tests for the payment service, covering both PagarMe and Stripe payment requests. - Added a script to ensure exact test runs with Jest, improving test execution accuracy.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fef3f47a82
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
fahmidareem3
left a comment
There was a problem hiding this comment.
Some small changes requested. Good PR!
|
Could you please take a look into the already merged integration test? It currently doesn’t look consistent with the others and feels a bit messy. If we follow the same pattern across all tests, it will be easier to maintain and extend them in the future. |
…configuration - Removed obsolete payment-related variables from the sample environment file. - Simplified payment service integration tests by eliminating unnecessary code and focusing on essential functionality.
…stomer retrieval and timeout settings - Added a timeout constant for integration tests to ensure consistent execution duration. - Updated the logic for finding an approved customer, simplifying the retrieval process and improving test reliability. - Enhanced error handling and logging for scenarios where no approved customers are found. - Refactored test cases for clarity and consistency, ensuring they adhere to the new timeout settings.
No description provided.