Handle hyphenated shex filenames correctly in @ldo/cli#147
Merged
jaxoncreed merged 3 commits intoo-development:mainfrom Mar 27, 2026
Merged
Handle hyphenated shex filenames correctly in @ldo/cli#147jaxoncreed merged 3 commits intoo-development:mainfrom
jaxoncreed merged 3 commits intoo-development:mainfrom
Conversation
jaxoncreed
requested changes
Mar 25, 2026
| @@ -1,3 +1,6 @@ | |||
| import { shexjToTyping } from "./typing/shexjToTyping"; | |||
| import { toCamelCase } from "./context/JsonLdContextBuilder.js"; | |||
Contributor
There was a problem hiding this comment.
Instead of this, change this and the one in context builder to use an NPM library.
Contributor
Author
There was a problem hiding this comment.
Addressed with https://www.npmjs.com/package/camelcase in b16b3a6.
Contributor
Author
There was a problem hiding this comment.
... but they're not equivalent. Another try...
Contributor
Author
mrkvon
force-pushed
the
fix-89-hyphen-shex
branch
3 times, most recently
from
e2df5d4 to
6ebfe95
Compare
This will allow testing output by mocking fs with memfs
mrkvon
force-pushed
the
fix-89-hyphen-shex
branch
from
6ebfe95 to
1e125eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89