WIP: Feat: Add support for shex imports to @ldo/cli#143
Draft
mrkvon wants to merge 6 commits intoo-development:mainfrom
Draft
WIP: Feat: Add support for shex imports to @ldo/cli#143mrkvon wants to merge 6 commits intoo-development:mainfrom
mrkvon wants to merge 6 commits intoo-development:mainfrom
Conversation
4234753 to
6bbdc0e
Compare
d3326da to
a404488
Compare
Putting things to what feels like more appropriate places, but it's not perfect.
for example import type TODO make sure .eslintrc is imported
255fb3b to
6f224c0
Compare
and other outstanding shape build issues
6f224c0 to
f53c09d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress.
Issues to address:
import type, butdts-domdoesn't seem to support that. Maybe we can run linter to fix this (fixable issue).import { Type as Type } from "./somewhere"could becomeimport { Type } when they match.