fix: Magic number in source listing limit#50
Open
mrwind-up-bird wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AutoFix: Magic number in source listing limit
Category: code-smell
Severity: low
Issue
The hardcoded limit of 100 in the min(limit, 100) expression is a magic number that should be defined as a named constant. This makes the code harder to maintain and the business rule less clear.
Fix
Replaced the magic number 100 with a named constant MAX_CHAT_LIST_LIMIT defined at the module level. This makes the business rule explicit and easier to maintain, following the project's pattern of using named constants for configuration values.
Generated by nyxCore AutoFix