Skip to content

fix: Unhandled JSON parse exceptions in streaming #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Unhandled JSON parse exceptions in streaming #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dashboard/widget/minirag-widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,10 @@
// Add placeholder assistant message for streaming
const assistantMsg = { role: 'assistant', content: '', sources: [] };
this._messages.push(assistantMsg);
this._render();

try {
if (e.message === 'Stream error') {
} else {
// JSON parse error - log and continue processing
console.warn('Failed to parse streaming response:', e.message, 'Data:', dataStr);
const resp = await fetch(`${this._config.apiUrl}/v1/chat`, {
method: 'POST',
headers: {
Expand Down