Skip to content

fix: Inefficient DOM manipulation in widget streaming #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Inefficient DOM manipulation in widget streaming #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions dashboard/widget/minirag-widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
const cssUrl = new URL('minirag-widget.css', scriptEl?.src || window.location.href).href;

class MiniRAGWidget extends HTMLElement {
this._lastMessageElement = null;
constructor() {
super();
this.attachShadow({ mode: 'open' });
Expand Down Expand Up @@ -100,11 +101,13 @@

this._messages.forEach(m => {
const div = document.createElement('div');
this._lastMessageElement = div; // Cache reference to last message element
div.className = `msg msg-${m.role}`;
div.textContent = m.content;

if (m.sources && m.sources.length > 0) {
const details = document.createElement('details');
this._lastMessageElement = null; // Clear cache when showing typing indicator
details.className = 'msg-sources';
const summary = document.createElement('summary');
summary.textContent = `${m.sources.length} source(s) used`;
Expand Down Expand Up @@ -180,15 +183,15 @@
// Focus input
requestAnimationFrame(() => input.focus());
}

async _send(text) {
this._messages.push({ role: 'user', content: text });
this._sending = true;

if (this._lastMessageElement) {
const last = this._lastMessageElement;
const msgs = this.shadowRoot.querySelector('.widget-messages');
if (msgs) {
// Add placeholder assistant message for streaming
const assistantMsg = { role: 'assistant', content: '', sources: [] };
this._messages.push(assistantMsg);
this._render();
this._lastMessageElement = null; // Clear cache on full re-render

try {
const resp = await fetch(`${this._config.apiUrl}/v1/chat`, {
Expand Down