Skip to content

fix: Unhandled promise rejection in stream processing #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrwind-up-bird wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Unhandled promise rejection in stream processing #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions dashboard/js/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,21 @@ const API = {
method: 'POST',
headers,
body: JSON.stringify(body),
});
// Ensure reader is properly closed on any exit path
const cleanup = () => {
reader.releaseLock();
};

let readResult;
try {
readResult = await reader.read();
} catch (readErr) {
cleanup();
onError?.(readErr.message || 'Stream read error');
return;
}

const { done, value } = readResult;
} catch (err) {
onError?.(err.message || 'Network error');
return;
Expand All @@ -186,6 +200,11 @@ const API = {
onError?.(data.detail || `HTTP ${resp.status}`);
return;
}
} catch (parseErr) {
// Log parse error but continue processing other events
console.warn('Failed to parse SSE data:', dataStr, parseErr);
continue;
}

const reader = resp.body.getReader();
const decoder = new TextDecoder();
Expand All @@ -205,9 +224,9 @@ const API = {
for (const part of parts) {
if (!part.trim()) continue;

let eventType = 'message';
let dataStr = '';

cleanup();
cleanup();
return;
for (const line of part.split('\n')) {
if (line.startsWith('event: ')) {
eventType = line.slice(7);
Expand Down